Skip to content

Commit deb5a25

Browse files
committed
net: hsr: remove synchronize_rcu() from hsr_add_port()
JIRA: https://issues.redhat.com/browse/RHEL-84547 commit a3b3d2d Author: Eric Dumazet <edumazet@google.com> Date: Tue Jan 7 14:47:01 2025 +0000 net: hsr: remove synchronize_rcu() from hsr_add_port() A synchronize_rcu() was added by mistake in commit c5a7591 ("net/hsr: Use list_head (and rcu) instead of array for slave devices.") RCU does not mandate to observe a grace period after list_add_tail_rcu(). Signed-off-by: Eric Dumazet <edumazet@google.com> Reviewed-by: Simon Horman <horms@kernel.org> Link: https://patch.msgid.link/20250107144701.503884-1-edumazet@google.com Signed-off-by: Paolo Abeni <pabeni@redhat.com> Signed-off-by: Felix Maurer <fmaurer@redhat.com>
1 parent 372c974 commit deb5a25

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

net/hsr/hsr_slave.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,6 @@ int hsr_add_port(struct hsr_priv *hsr, struct net_device *dev,
204204
}
205205

206206
list_add_tail_rcu(&port->port_list, &hsr->ports);
207-
synchronize_rcu();
208207

209208
master = hsr_port_get_hsr(hsr, HSR_PT_MASTER);
210209
netdev_update_features(master->dev);

0 commit comments

Comments
 (0)