usb: core: config: Use USB API functions rather than constants

Desnes Nunes · Desnes Nunes · commit de95b8f50e81 · 2025-09-25T22:03:50.000-03:00
JIRA: https://issues.redhat.com/browse/RHEL-116007 commit eb25dcf Author: Chen Ni <nichen@iscas.ac.cn> Date: Mon, 19 May 2025 14:13:17 +0800 Use the function usb_endpoint_num() rather than constants. The Coccinelle semantic patch is as follows: @@ struct usb_endpoint_descriptor *epd; @@ - (epd->bEndpointAddress & \(USB_ENDPOINT_NUMBER_MASK\|0x0f\)) + usb_endpoint_num(epd) Signed-off-by: Chen Ni <nichen@iscas.ac.cn> Link: https://lore.kernel.org/r/20250519061317.724602-1-nichen@iscas.ac.cn Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Desnes Nunes <desnesn@redhat.com>
diff --git a/drivers/usb/core/config.c b/drivers/usb/core/config.c
@@ -307,7 +307,7 @@ static int usb_parse_endpoint(struct device *ddev, int cfgno,
 		goto skip_to_next_endpoint_or_interface_descriptor;
 	}
 
-	i = d->bEndpointAddress & USB_ENDPOINT_NUMBER_MASK;
+	i = usb_endpoint_num(d);
 	if (i == 0) {
 		dev_notice(ddev, "config %d interface %d altsetting %d has an "
 		    "invalid descriptor for endpoint zero, skipping\n",

Original file line number	Diff line number	Diff line change
`@@ -307,7 +307,7 @@ static int usb_parse_endpoint(struct device *ddev, int cfgno,`
`307`	`307`	`goto skip_to_next_endpoint_or_interface_descriptor;`
`308`	`308`	`}`
`309`	`309`
`310`		`- i = d->bEndpointAddress & USB_ENDPOINT_NUMBER_MASK;`
	`310`	`+ i = usb_endpoint_num(d);`
`311`	`311`	`if (i == 0) {`
`312`	`312`	`dev_notice(ddev, "config %d interface %d altsetting %d has an "`
`313`	`313`	`"invalid descriptor for endpoint zero, skipping\n",`