scsi: target: spc: Fix RSOC parameter data header size

maurizio-lombardi · maurizio-lombardi · commit d8f8b8b3af9e · 2025-08-29T15:31:29.000+02:00
JIRA: https://issues.redhat.com/browse/RHEL-111938 The SPC document states that "The COMMAND DATA LENGTH field indicates the length in bytes of the command descriptor list". The length should be subtracted by 4 to represent the length of the description list, not 3. Signed-off-by: Chaohai Chen <wdhh66@163.com> Link: https://lore.kernel.org/r/20250115070739.216154-1-wdhh66@163.com Reviewed-by: Dmitry Bogdanov <d.bogdanov@yadro.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> (cherry picked from commit b505323) Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
diff --git a/drivers/target/target_core_spc.c b/drivers/target/target_core_spc.c
@@ -2243,7 +2243,7 @@ spc_emulate_report_supp_op_codes(struct se_cmd *cmd)
 			response_length += spc_rsoc_encode_command_descriptor(
 					&buf[response_length], rctd, descr);
 		}
-		put_unaligned_be32(response_length - 3, buf);
+		put_unaligned_be32(response_length - 4, buf);
 	} else {
 		response_length = spc_rsoc_encode_one_command_descriptor(
 				&buf[response_length], rctd, descr,

Original file line number	Diff line number	Diff line change
`@@ -2243,7 +2243,7 @@ spc_emulate_report_supp_op_codes(struct se_cmd *cmd)`
`2243`	`2243`	`response_length += spc_rsoc_encode_command_descriptor(`
`2244`	`2244`	`&buf[response_length], rctd, descr);`
`2245`	`2245`	`}`
`2246`		`- put_unaligned_be32(response_length - 3, buf);`
	`2246`	`+ put_unaligned_be32(response_length - 4, buf);`
`2247`	`2247`	`} else {`
`2248`	`2248`	`response_length = spc_rsoc_encode_one_command_descriptor(`
`2249`	`2249`	`&buf[response_length], rctd, descr,`