selftests: net: really check for bg process completion

Hangbin Liu · Hangbin Liu · commit d4d8fdf3ca94 · 2025-01-13T10:18:18.000+08:00
JIRA: https://issues.redhat.com/browse/RHEL-73281 Upstream Status: net.git commit 52ed077 commit 52ed077 Author: Paolo Abeni <pabeni@redhat.com> Date: Tue Nov 5 19:23:51 2024 +0100 selftests: net: really check for bg process completion A recent refactor transformed the check for process completion in a true statement, due to a typo. As a result, the relevant test-case is unable to catch the regression it was supposed to detect. Restore the correct condition. Fixes: 691bb4e ("selftests: net: avoid just another constant wait") Signed-off-by: Paolo Abeni <pabeni@redhat.com> Reviewed-by: David Ahern <dsahern@kernel.org> Link: https://patch.msgid.link/0e6f213811f8e93a235307e683af8225cc6277ae.1730828007.git.pabeni@redhat.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Hangbin Liu <haliu@redhat.com>
diff --git a/tools/testing/selftests/net/pmtu.sh b/tools/testing/selftests/net/pmtu.sh
@@ -1969,7 +1969,7 @@ check_running() {
 	pid=${1}
 	cmd=${2}
 
-	[ "$(cat /proc/${pid}/cmdline 2>/dev/null | tr -d '\0')" = "{cmd}" ]
+	[ "$(cat /proc/${pid}/cmdline 2>/dev/null | tr -d '\0')" = "${cmd}" ]
 }
 
 test_cleanup_vxlanX_exception() {

Original file line number	Diff line number	Diff line change
`@@ -1969,7 +1969,7 @@ check_running() {`
`1969`	`1969`	`pid=${1}`
`1970`	`1970`	`cmd=${2}`
`1971`	`1971`
`1972`		`- [ "$(cat /proc/${pid}/cmdline 2>/dev/null \| tr -d '\0')" = "{cmd}" ]`
	`1972`	`+ [ "$(cat /proc/${pid}/cmdline 2>/dev/null \| tr -d '\0')" = "${cmd}" ]`
`1973`	`1973`	`}`
`1974`	`1974`
`1975`	`1975`	`test_cleanup_vxlanX_exception() {`