Skip to content

Commit d40ae90

Browse files
powerpc/prom_init: Fix shellcheck warnings
Fix "Double quote to prevent globbing and word splitting." warning from shellcheck Tested-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com> Reviewed-by: Stephen Rothwell <sfr@cab.auug.org.au> Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com> Link: https://patch.msgid.link/20250518044107.39928-3-maddy@linux.ibm.com
1 parent 88688a2 commit d40ae90

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

arch/powerpc/kernel/prom_init_check.sh

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515

1616
has_renamed_memintrinsics()
1717
{
18-
grep -q "^CONFIG_KASAN=y$" ${KCONFIG_CONFIG} && \
19-
! grep -q "^CONFIG_CC_HAS_KASAN_MEMINTRINSIC_PREFIX=y" ${KCONFIG_CONFIG}
18+
grep -q "^CONFIG_KASAN=y$" "${KCONFIG_CONFIG}" && \
19+
! grep -q "^CONFIG_CC_HAS_KASAN_MEMINTRINSIC_PREFIX=y" "${KCONFIG_CONFIG}"
2020
}
2121

2222
if has_renamed_memintrinsics
@@ -42,15 +42,15 @@ check_section()
4242
{
4343
file=$1
4444
section=$2
45-
size=$(objdump -h -j $section $file 2>/dev/null | awk "\$2 == \"$section\" {print \$3}")
45+
size=$(objdump -h -j "$section" "$file" 2>/dev/null | awk "\$2 == \"$section\" {print \$3}")
4646
size=${size:-0}
47-
if [ $size -ne 0 ]; then
47+
if [ "$size" -ne 0 ]; then
4848
ERROR=1
4949
echo "Error: Section $section not empty in prom_init.c" >&2
5050
fi
5151
}
5252

53-
for UNDEF in $($NM -u $OBJ | awk '{print $2}')
53+
for UNDEF in $($NM -u "$OBJ" | awk '{print $2}')
5454
do
5555
# On 64-bit nm gives us the function descriptors, which have
5656
# a leading . on the name, so strip it off here.
@@ -87,8 +87,8 @@ do
8787
fi
8888
done
8989

90-
check_section $OBJ .data
91-
check_section $OBJ .bss
92-
check_section $OBJ .init.data
90+
check_section "$OBJ" .data
91+
check_section "$OBJ" .bss
92+
check_section "$OBJ" .init.data
9393

9494
exit $ERROR

0 commit comments

Comments
 (0)