crypto: qat - ensure correct order in VF restarting handler

JIRA: https://issues.redhat.com/browse/RHEL-52749
Upstream Status: merged into the linux.git

commit cd8d2d7
Author: Michal Witwicki <michal.witwicki@intel.com>
Date:   Wed Jul 17 07:44:59 2024 -0400

    crypto: qat - ensure correct order in VF restarting handler

    In the process of sending the ADF_PF2VF_MSGTYPE_RESTARTING message to
    Virtual Functions (VFs), the Physical Function (PF) should set the
    `vf->restarting` flag to true before dispatching the message.
    This change is necessary to prevent a race condition where the handling
    of the ADF_VF2PF_MSGTYPE_RESTARTING_COMPLETE message (which sets the
    `vf->restarting` flag to false) runs immediately after the message is sent,
    but before the flag is set to true.

    Set the `vf->restarting` to true before sending the message
    ADF_PF2VF_MSGTYPE_RESTARTING, if supported by the version of the
    protocol and if the VF is started.

    Fixes: ec26f8e ("crypto: qat - update PFVF protocol for recovery")
    Signed-off-by: Michal Witwicki <michal.witwicki@intel.com>
    Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
    Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Signed-off-by: Vladis Dronov <vdronov@redhat.com>

Author: nefigtut

drivers/crypto/intel/qat/qat_common/adf_pfvf_pf_msg.c

@@ -18,14 +18,17 @@ void adf_pf2vf_notify_restarting(struct adf_accel_dev *accel_dev)
 
 	dev_dbg(&GET_DEV(accel_dev), "pf2vf notify restarting\n");
 	for (i = 0, vf = accel_dev->pf.vf_info; i < num_vfs; i++, vf++) {
-		vf->restarting = false;
+		if (vf->init && vf->vf_compat_ver >= ADF_PFVF_COMPAT_FALLBACK)
+			vf->restarting = true;
+		else
+			vf->restarting = false;
+
 		if (!vf->init)
 			continue;
+
 		if (adf_send_pf2vf_msg(accel_dev, i, msg))
 			dev_err(&GET_DEV(accel_dev),
 				"Failed to send restarting msg to VF%d\n", i);
-		else if (vf->vf_compat_ver >= ADF_PFVF_COMPAT_FALLBACK)
-			vf->restarting = true;
 	}
 }