Skip to content

Commit ce129ca

Browse files
committed
tools build: Remove the libunwind feature tests from the ones detected when test-all.o builds
JIRA: https://issues.redhat.com/browse/RHEL-77935 upstream ======== commit b40fbeb Author: Arnaldo Carvalho de Melo <acme@redhat.com> Date: Wed Dec 11 12:24:21 2024 -0300 description =========== We have a tools/build/feature/test-all.c that has the most common set of features that perf uses and are expected to have its development files available when building perf. When we made libwunwind opt-in we forgot to remove them from the list of features that are assumed to be available when test-all.c builds, remove them. Before this patch: $ rm -rf /tmp/b ; mkdir /tmp/b ; make -C tools/perf O=/tmp/b feature-dump ; grep feature-libunwind-aarch64= /tmp/b/FEATURE-DUMP feature-libunwind-aarch64=1 $ Even tho this not being test built and those header files being available: $ head -5 tools/build/feature/test-libunwind-aarch64.c // SPDX-License-Identifier: GPL-2.0 #include <libunwind-aarch64.h> #include <stdlib.h> extern int UNW_OBJ(dwarf_search_unwind_table) (unw_addr_space_t as, $ After this patch: $ grep feature-libunwind- /tmp/b/FEATURE-DUMP $ Now an audit on what is being enabled when test-all.c builds will be performed. Fixes: 176c9d1 ("tools features: Don't check for libunwind devel files by default") Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Ian Rogers <irogers@google.com> Cc: James Clark <james.clark@linaro.org> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Kan Liang <kan.liang@linux.intel.com> Cc: Namhyung Kim <namhyung@kernel.org> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> Signed-off-by: Michael Petlan <mpetlan@redhat.com>
1 parent a242846 commit ce129ca

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

tools/build/Makefile.feature

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -89,13 +89,6 @@ FEATURE_TESTS_EXTRA := \
8989
libbfd-liberty \
9090
libbfd-liberty-z \
9191
libopencsd \
92-
libunwind-x86 \
93-
libunwind-x86_64 \
94-
libunwind-arm \
95-
libunwind-aarch64 \
96-
libunwind-debug-frame \
97-
libunwind-debug-frame-arm \
98-
libunwind-debug-frame-aarch64 \
9992
cxx \
10093
llvm \
10194
clang \

0 commit comments

Comments
 (0)