irqchip/mvebu-gicp: Fix an IS_ERR() vs NULL check in probe()

Dan Carpenter · KAGA-KOKO · commit c8bb0f00a488 · 2025-08-24T12:00:47.000+02:00
ioremap() never returns error pointers, it returns NULL on error. Fix the check to match. Fixes: 3c3d7db ("irqchip/mvebu-gicp: Clear pending interrupts on init") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Link: https://lore.kernel.org/all/aKRGcgMeaXm2TMIC@stanley.mountain
diff --git a/drivers/irqchip/irq-mvebu-gicp.c b/drivers/irqchip/irq-mvebu-gicp.c
@@ -238,7 +238,7 @@ static int mvebu_gicp_probe(struct platform_device *pdev)
 	}
 
 	base = ioremap(gicp->res->start, resource_size(gicp->res));
-	if (IS_ERR(base)) {
+	if (!base) {
 		dev_err(&pdev->dev, "ioremap() failed. Unable to clear pending interrupts.\n");
 	} else {
 		for (i = 0; i < 64; i++)

Original file line number	Diff line number	Diff line change
`@@ -238,7 +238,7 @@ static int mvebu_gicp_probe(struct platform_device *pdev)`
`238`	`238`	`}`
`239`	`239`
`240`	`240`	`base = ioremap(gicp->res->start, resource_size(gicp->res));`
`241`		`- if (IS_ERR(base)) {`
	`241`	`+ if (!base) {`
`242`	`242`	`dev_err(&pdev->dev, "ioremap() failed. Unable to clear pending interrupts.\n");`
`243`	`243`	`} else {`
`244`	`244`	`for (i = 0; i < 64; i++)`