Skip to content

Commit c3ea26a

Browse files
nvme-rdma: fix possible use-after-free in transport error_recovery work
jira VULN-32687 cve CVE-2022-48788 commit-author Sagi Grimberg <sagi@grimberg.me> commit b6bb172 While nvme_rdma_submit_async_event_work is checking the ctrl and queue state before preparing the AER command and scheduling io_work, in order to fully prevent a race where this check is not reliable the error recovery work must flush async_event_work before continuing to destroy the admin queue after setting the ctrl state to RESETTING such that there is no race .submit_async_event and the error recovery handler itself changing the ctrl state. Signed-off-by: Sagi Grimberg <sagi@grimberg.me> (cherry picked from commit b6bb172) Signed-off-by: Pratham Patel <ppatel@ciq.com>
1 parent e9aeb82 commit c3ea26a

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/nvme/host/rdma.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1060,6 +1060,7 @@ static void nvme_rdma_error_recovery_work(struct work_struct *work)
10601060
struct nvme_rdma_ctrl, err_work);
10611061

10621062
nvme_stop_keep_alive(&ctrl->ctrl);
1063+
flush_work(&ctrl->ctrl.async_event_work);
10631064
nvme_rdma_teardown_io_queues(ctrl, false);
10641065
nvme_start_queues(&ctrl->ctrl);
10651066
nvme_rdma_teardown_admin_queue(ctrl, false);

0 commit comments

Comments
 (0)