cpufreq/amd-pstate: Fix per-policy boost flag incorrect when fail

JIRA: https://issues.redhat.com/browse/RHEL-75923

commit fa80351
Author: Lifeng Zheng <zhenglifeng1@huawei.com>
Date:   Fri Jan 10 17:19:49 2025 +0800

    cpufreq/amd-pstate: Fix per-policy boost flag incorrect when fail

    Commit c8c68c3 ("cpufreq: amd-pstate: initialize core precision
    boost state") sets per-policy boost flag to false when boost fail.
    However, this boost flag will be set to reverse value in
    store_local_boost() and cpufreq_boost_trigger_state() in cpufreq.c. This
    will cause the per-policy boost flag set to true when fail to set boost.
    Remove the extra assignment in amd_pstate_set_boost() and keep all
    operations on per-policy boost flag outside of set_boost() to fix this
    problem.

    Fixes: c8c68c3 ("cpufreq: amd-pstate: initialize core precision boost state")
    Signed-off-by: Lifeng Zheng <zhenglifeng1@huawei.com>
    Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
    Link: https://lore.kernel.org/r/20250110091949.3610770-1-zhenglifeng1@huawei.com
    Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>

Signed-off-by: David Arcari <darcari@redhat.com>

Author: darcari

drivers/cpufreq/amd-pstate.c

@@ -747,7 +747,6 @@ static int amd_pstate_set_boost(struct cpufreq_policy *policy, int state)
 	guard(mutex)(&amd_pstate_driver_lock);
 
 	ret = amd_pstate_cpu_boost_update(policy, state);
-	policy->boost_enabled = !ret ? state : false;
 	refresh_frequency_limits(policy);
 
 	return ret;