Skip to content

Commit bf6fb4a

Browse files
Sharq7broonie
authored andcommitted
ASOC: max98090/91: fix for filter configuration: AHPF removed DMIC2_HPF added
The filter configuration register(0x26) has AHPF(bit6) for primary record path, which is common in max98090 and max98091 and has been defined as DAPM suppy widget as "AHPF" in "struct snd_soc_dapm_widget max98090_dapm_widget[]". It is the DC-Blocking filter for the primary record path. But the same functionality for secondary record path in the configuration register(0x26) is DMIC2_HPF(bit2). It is not present as a DAPM supply widget in the current code. With this patch adding it as a DAPM supply widget. In the current code, the mics on secondary record path in code are named as "DMIC3" and "DMIC4", so accordingly naming DMIC2_HPF(bit2) as "DMIC34_HPF", and declaring it as a DAPM supply widget in "struct snd_soc_dapm_widget max98091_dapm_widget[]". Also it is specific to max98091, and should be visible or working only when max98091 codec chip is used. Therefore, written in "max98091_dapm_widget[]". As "AHPF" is not part of secondary record path, replacing it with "DMIC34_HPF" in the ALSA routes to "DMIC3" and "DMIC4" in "max98091_dapm_routes[]". Signed-off-by: Sharique Mohammad <sharq0406@gmail.com> Link: https://patch.msgid.link/20251016151152.1107083-1-sharq0406@gmail.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent ef30cb1 commit bf6fb4a

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

sound/soc/codecs/max98090.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1239,6 +1239,8 @@ static const struct snd_soc_dapm_widget max98091_dapm_widgets[] = {
12391239
SND_SOC_DAPM_SUPPLY("DMIC4_ENA", M98090_REG_DIGITAL_MIC_ENABLE,
12401240
M98090_DIGMIC4_SHIFT, 0, max98090_shdn_event,
12411241
SND_SOC_DAPM_POST_PMU),
1242+
SND_SOC_DAPM_SUPPLY("DMIC34_HPF", M98090_REG_FILTER_CONFIG,
1243+
M98090_FLT_DMIC34HPF_SHIFT, 0, NULL, 0),
12421244
};
12431245

12441246
static const struct snd_soc_dapm_route max98090_dapm_routes[] = {
@@ -1427,8 +1429,8 @@ static const struct snd_soc_dapm_route max98091_dapm_routes[] = {
14271429
/* DMIC inputs */
14281430
{"DMIC3", NULL, "DMIC3_ENA"},
14291431
{"DMIC4", NULL, "DMIC4_ENA"},
1430-
{"DMIC3", NULL, "AHPF"},
1431-
{"DMIC4", NULL, "AHPF"},
1432+
{"DMIC3", NULL, "DMIC34_HPF"},
1433+
{"DMIC4", NULL, "DMIC34_HPF"},
14321434
};
14331435

14341436
static int max98090_add_widgets(struct snd_soc_component *component)

0 commit comments

Comments
 (0)