Skip to content

Commit bf2fbe4

Browse files
committed
bnxt_en: Set backplane link modes correctly for ethtool
JIRA: https://issues.redhat.com/browse/RHEL-54644 commit 5007991 Author: Shravya KN <shravya.k-n@broadcom.com> Date: Fri Nov 22 14:45:42 2024 -0800 bnxt_en: Set backplane link modes correctly for ethtool Use the return value from bnxt_get_media() to determine the port and link modes. bnxt_get_media() returns the proper BNXT_MEDIA_KR when the PHY is backplane. This will correct the ethtool settings for backplane devices. Fixes: 5d4e1bf ("bnxt_en: extend media types to supported and autoneg modes") Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com> Signed-off-by: Shravya KN <shravya.k-n@broadcom.com> Signed-off-by: Michael Chan <michael.chan@broadcom.com> Signed-off-by: Paolo Abeni <pabeni@redhat.com> Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
1 parent c2b3ef1 commit bf2fbe4

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2844,19 +2844,24 @@ static int bnxt_get_link_ksettings(struct net_device *dev,
28442844
}
28452845

28462846
base->port = PORT_NONE;
2847-
if (link_info->media_type == PORT_PHY_QCFG_RESP_MEDIA_TYPE_TP) {
2847+
if (media == BNXT_MEDIA_TP) {
28482848
base->port = PORT_TP;
28492849
linkmode_set_bit(ETHTOOL_LINK_MODE_TP_BIT,
28502850
lk_ksettings->link_modes.supported);
28512851
linkmode_set_bit(ETHTOOL_LINK_MODE_TP_BIT,
28522852
lk_ksettings->link_modes.advertising);
2853+
} else if (media == BNXT_MEDIA_KR) {
2854+
linkmode_set_bit(ETHTOOL_LINK_MODE_Backplane_BIT,
2855+
lk_ksettings->link_modes.supported);
2856+
linkmode_set_bit(ETHTOOL_LINK_MODE_Backplane_BIT,
2857+
lk_ksettings->link_modes.advertising);
28532858
} else {
28542859
linkmode_set_bit(ETHTOOL_LINK_MODE_FIBRE_BIT,
28552860
lk_ksettings->link_modes.supported);
28562861
linkmode_set_bit(ETHTOOL_LINK_MODE_FIBRE_BIT,
28572862
lk_ksettings->link_modes.advertising);
28582863

2859-
if (link_info->media_type == PORT_PHY_QCFG_RESP_MEDIA_TYPE_DAC)
2864+
if (media == BNXT_MEDIA_CR)
28602865
base->port = PORT_DA;
28612866
else
28622867
base->port = PORT_FIBRE;

0 commit comments

Comments
 (0)