Skip to content

Commit becc639

Browse files
lategoodbyekuba-moo
authored andcommitted
qca_spi: Make driver probing reliable
The module parameter qcaspi_pluggable controls if QCA7000 signature should be checked at driver probe (current default) or not. Unfortunately this could fail in case the chip is temporary in reset, which isn't under total control by the Linux host. So disable this check per default in order to avoid unexpected probe failures. Fixes: 291ab06 ("net: qualcomm: new Ethernet over SPI driver for QCA7000") Signed-off-by: Stefan Wahren <wahrenst@gmx.net> Link: https://patch.msgid.link/20241206184643.123399-3-wahrenst@gmx.net Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 4dba406 commit becc639

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/ethernet/qualcomm/qca_spi.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ MODULE_PARM_DESC(qcaspi_burst_len, "Number of data bytes per burst. Use 1-5000."
5454

5555
#define QCASPI_PLUGGABLE_MIN 0
5656
#define QCASPI_PLUGGABLE_MAX 1
57-
static int qcaspi_pluggable = QCASPI_PLUGGABLE_MIN;
57+
static int qcaspi_pluggable = QCASPI_PLUGGABLE_MAX;
5858
module_param(qcaspi_pluggable, int, 0);
5959
MODULE_PARM_DESC(qcaspi_pluggable, "Pluggable SPI connection (yes/no).");
6060

0 commit comments

Comments
 (0)