Skip to content

Commit becbc52

Browse files
author
Desnes Nunes
committed
xhci: dbctty: disable ECHO flag by default
JIRA: https://issues.redhat.com/browse/RHEL-116007 commit 2b857d6 Author: =?UTF-8?q?=C5=81ukasz=20Bartosik?= <ukaszb@chromium.org> Date: Fri, 27 Jun 2025 17:41:21 +0300 When /dev/ttyDBC0 device is created then by default ECHO flag is set for the terminal device. However if data arrives from a peer before application using /dev/ttyDBC0 applies its set of terminal flags then the arriving data will be echoed which might not be desired behavior. Fixes: 4521f16 ("xhci: dbctty: split dbc tty driver registration and unregistration functions.") Cc: stable <stable@kernel.org> Signed-off-by: Łukasz Bartosik <ukaszb@chromium.org> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com> Link: https://lore.kernel.org/stable/20250610111802.18742-1-ukaszb%40chromium.org Link: https://lore.kernel.org/r/20250627144127.3889714-4-mathias.nyman@linux.intel.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Desnes Nunes <desnesn@redhat.com>
1 parent 1604ba5 commit becbc52

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/usb/host/xhci-dbgtty.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -617,6 +617,7 @@ int dbc_tty_init(void)
617617
dbc_tty_driver->type = TTY_DRIVER_TYPE_SERIAL;
618618
dbc_tty_driver->subtype = SERIAL_TYPE_NORMAL;
619619
dbc_tty_driver->init_termios = tty_std_termios;
620+
dbc_tty_driver->init_termios.c_lflag &= ~ECHO;
620621
dbc_tty_driver->init_termios.c_cflag =
621622
B9600 | CS8 | CREAD | HUPCL | CLOCAL;
622623
dbc_tty_driver->init_termios.c_ispeed = 9600;

0 commit comments

Comments
 (0)