Skip to content

Commit bba2433

Browse files
dmantipovgregkh
authored andcommitted
wifi: rtw88: do not ignore hardware read error during DPK
[ Upstream commit 20d3c19 ] In 'rtw8822c_dpk_cal_coef1()', do not ignore error returned by 'check_hw_ready()' but issue a warning to denote possible DPK issue. Compile tested only. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 5227c2e ("rtw88: 8822c: add SW DPK support") Suggested-by: Ping-Ke Shih <pkshih@realtek.com> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com> Link: https://patch.msgid.link/20250415090720.194048-1-dmantipov@yandex.ru Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent c5b738a commit bba2433

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/net/wireless/realtek/rtw88/rtw8822c.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3993,7 +3993,8 @@ static void rtw8822c_dpk_cal_coef1(struct rtw_dev *rtwdev)
39933993
rtw_write32(rtwdev, REG_NCTL0, 0x00001148);
39943994
rtw_write32(rtwdev, REG_NCTL0, 0x00001149);
39953995

3996-
check_hw_ready(rtwdev, 0x2d9c, MASKBYTE0, 0x55);
3996+
if (!check_hw_ready(rtwdev, 0x2d9c, MASKBYTE0, 0x55))
3997+
rtw_warn(rtwdev, "DPK stuck, performance may be suboptimal");
39973998

39983999
rtw_write8(rtwdev, 0x1b10, 0x0);
39994000
rtw_write32_mask(rtwdev, REG_NCTL0, BIT_SUBPAGE, 0x0000000c);

0 commit comments

Comments
 (0)