Merge: pinctrl: intel: platform: updates to fix error path in device_for_each_child_node()

MR: https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9/-/merge_requests/5763

Description:  
updates for pinctrl: intel: platform: fix error path in device_for_each_child_node()  
  
JIRA: https://issues.redhat.com/browse/RHEL-66957  
CVE: CVE-2024-50197  
  
Build Info: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=65873024  
  
Tested: Successful platform test results on Intel (intel-arrowlake-h-01) system.

The following 8 commits are not fixes to 365130f they just use 
the new routine provide by 365130f. If needed in the future 
they can be bought in individually. Trying to limit the changes for this CVE and
that is another reason to not bring them in now.

Omitted-fix: d13df21 ("Input: adcto -joystick - use device_for_each_child_node_scoped()")

Omitted-fix: 44f9c7c ("Input: adc-keys - use device_for_each_child_node_scoped()")

Omitted-fix: 1102db7 ("Input: gpio_keys_polled - use device_for_each_child_node_scoped()")

Omitted-fix: c90a851 ("Input: gpio_keys - use device_for_each_child_node_scoped()")

Omitted-fix: 4f210af ("Input: qt1050 - use device_for_each_child_node_scoped()")

Omitted-fix: 4256d47 ("Input: iqs269a - use device_for_each_child_node_scoped()")

Omitted-fix: 1ee1237 ("hwmon: (gsc-hwmon) use device_for_each_child_node_scoped()")

Omitted-fix: 234c074 ("hwmon: (ltc2991) use device_for_each_child_node_scoped()")

  
Signed-off-by: Steve Best <sbest@redhat.com>

Approved-by: Tony Camuso <tcamuso@redhat.com>
Approved-by: Desnes Nunes <desnesn@redhat.com>
Approved-by: CKI KWF Bot <cki-ci-bot+kwf-gitlab-com@redhat.com>

Merged-by: Rado Vrbovsky <rvrbovsk@redhat.com>

Author: emmil

drivers/pinctrl/intel/pinctrl-intel-platform.c

@@ -90,7 +90,6 @@ static int intel_platform_pinctrl_prepare_community(struct device *dev,
 						    struct intel_community *community,
 						    struct intel_platform_pins *pins)
 {
-	struct fwnode_handle *child;
 	struct intel_padgroup *gpps;
 	unsigned int group;
 	size_t ngpps;
@@ -131,7 +130,7 @@ static int intel_platform_pinctrl_prepare_community(struct device *dev,
 		return -ENOMEM;
 
 	group = 0;
-	device_for_each_child_node(dev, child) {
+	device_for_each_child_node_scoped(dev, child) {
 		struct intel_padgroup *gpp = &gpps[group];
 
 		gpp->reg_num = group;

include/linux/property.h

@@ -11,6 +11,7 @@
 #define _LINUX_PROPERTY_H_
 
 #include <linux/bits.h>
+#include <linux/cleanup.h>
 #include <linux/fwnode.h>
 #include <linux/types.h>
 
@@ -140,6 +141,11 @@ struct fwnode_handle *device_get_next_child_node(const struct device *dev,
 	for (child = device_get_next_child_node(dev, NULL); child;	\
 	     child = device_get_next_child_node(dev, child))
 
+#define device_for_each_child_node_scoped(dev, child)			\
+	for (struct fwnode_handle *child __free(fwnode_handle) =	\
+		device_get_next_child_node(dev, NULL);			\
+	     child; child = device_get_next_child_node(dev, child))
+
 struct fwnode_handle *fwnode_get_named_child_node(const struct fwnode_handle *fwnode,
 						  const char *childname);
 struct fwnode_handle *device_get_named_child_node(const struct device *dev,
@@ -148,6 +154,8 @@ struct fwnode_handle *device_get_named_child_node(const struct device *dev,
 struct fwnode_handle *fwnode_handle_get(struct fwnode_handle *fwnode);
 void fwnode_handle_put(struct fwnode_handle *fwnode);
 
+DEFINE_FREE(fwnode_handle, struct fwnode_handle *, fwnode_handle_put(_T))
+
 int fwnode_irq_get(const struct fwnode_handle *fwnode, unsigned int index);
 int fwnode_irq_get_byname(const struct fwnode_handle *fwnode, const char *name);