Skip to content

Commit b2cf20d

Browse files
committed
s390/pgtable: Switch read and write softbits for puds
JIRA: https://issues.redhat.com/browse/RHEL-74362 Tested: by me commit 3e93d49 Author: Claudio Imbrenda <imbrenda@linux.ibm.com> Date: Mon Apr 29 16:34:08 2024 +0200 s390/pgtable: Switch read and write softbits for puds There is no reason for the read and write softbits to be swapped in the puds compared to pmds. They are different only because the softbits for puds were introduced at the same time when the softbits for pmds were swapped. The current implementation is not wrong per se, since the macros are defined correctly; only the documentation does not reflect reality. With this patch, the read and write softbits for large pmd and large puds will have the same layout, and will match the existing documentation. Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com> Reviewed-by: Heiko Carstens <hca@linux.ibm.com> Link: https://lore.kernel.org/r/20240429143409.49892-2-imbrenda@linux.ibm.com Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com> Signed-off-by: Aristeu Rozanski <arozansk@redhat.com>
1 parent 4d87a24 commit b2cf20d

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

arch/s390/include/asm/pgtable.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -266,8 +266,8 @@ static inline int is_module_addr(void *addr)
266266
#define _REGION3_ENTRY_DIRTY 0x2000 /* SW region dirty bit */
267267
#define _REGION3_ENTRY_YOUNG 0x1000 /* SW region young bit */
268268
#define _REGION3_ENTRY_LARGE 0x0400 /* RTTE-format control, large page */
269-
#define _REGION3_ENTRY_READ 0x0002 /* SW region read bit */
270-
#define _REGION3_ENTRY_WRITE 0x0001 /* SW region write bit */
269+
#define _REGION3_ENTRY_WRITE 0x0002 /* SW region write bit */
270+
#define _REGION3_ENTRY_READ 0x0001 /* SW region read bit */
271271

272272
#ifdef CONFIG_MEM_SOFT_DIRTY
273273
#define _REGION3_ENTRY_SOFT_DIRTY 0x4000 /* SW region soft dirty bit */

0 commit comments

Comments
 (0)