Skip to content

Commit b13ba2b

Browse files
Karan Kumarjohnmeneghini
authored andcommitted
scsi: fnic: Fix indentation and remove unnecessary parenthesis
JIRA: https://issues.redhat.com/browse/RHEL-72902 Fix indentation in fdls_disc.c to fix kernel test robot warnings. Remove unnecessary parentheses to fix checkpatch check. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/r/202502141403.1PcpwyJp-lkp@intel.com/ Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Closes: https://lore.kernel.org/r/202502141403.1PcpwyJp-lkp@intel.com/ Fixes: a63e78e ("scsi: fnic: Add support for fabric based solicited requests and responses") Reviewed-by: Sesidhar Baddela <sebaddel@cisco.com> Reviewed-by: Arulprabhu Ponnusamy <arulponn@cisco.com> Reviewed-by: Gian Carlo Boffa <gcboffa@cisco.com> Reviewed-by: Arun Easi <aeasi@cisco.com> Signed-off-by: Karan Tilak Kumar <kartilak@cisco.com> Link: https://lore.kernel.org/r/20250225215013.4875-1-kartilak@cisco.com Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> (cherry picked from commit 9ae7563) Signed-off-by: Karan Kumar <karkumar@redhat.com>
1 parent 91a8f05 commit b13ba2b

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

drivers/scsi/fnic/fdls_disc.c

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -318,8 +318,8 @@ void fdls_schedule_oxid_free_retry_work(struct work_struct *work)
318318
"Schedule oxid free. oxid idx: %d\n", idx);
319319

320320
spin_unlock_irqrestore(&fnic->fnic_lock, fnic->lock_flags);
321-
reclaim_entry = (struct reclaim_entry_s *)
322-
kzalloc(sizeof(struct reclaim_entry_s), GFP_KERNEL);
321+
reclaim_entry = (struct reclaim_entry_s *)
322+
kzalloc(sizeof(struct reclaim_entry_s), GFP_KERNEL);
323323
spin_lock_irqsave(&fnic->fnic_lock, fnic->lock_flags);
324324

325325
if (!reclaim_entry) {
@@ -338,7 +338,7 @@ void fdls_schedule_oxid_free_retry_work(struct work_struct *work)
338338
/* unlikely scenario, free the allocated memory and continue */
339339
kfree(reclaim_entry);
340340
}
341-
}
341+
}
342342

343343
spin_unlock_irqrestore(&fnic->fnic_lock, fnic->lock_flags);
344344
}
@@ -1563,9 +1563,9 @@ void fdls_send_fabric_logo(struct fnic_iport_s *iport)
15631563

15641564
iport->fabric.flags &= ~FNIC_FDLS_FABRIC_ABORT_ISSUED;
15651565

1566-
FNIC_FCS_DBG(KERN_INFO, fnic->host, fnic->fnic_num,
1567-
"0x%x: FDLS send fabric LOGO with oxid: 0x%x",
1568-
iport->fcid, oxid);
1566+
FNIC_FCS_DBG(KERN_INFO, fnic->host, fnic->fnic_num,
1567+
"0x%x: FDLS send fabric LOGO with oxid: 0x%x",
1568+
iport->fcid, oxid);
15691569

15701570
fnic_send_fcoe_frame(iport, frame, frame_size);
15711571

@@ -4655,13 +4655,13 @@ fnic_fdls_validate_and_get_frame_type(struct fnic_iport_s *iport,
46554655
d_id = ntoh24(fchdr->fh_d_id);
46564656

46574657
/* some common validation */
4658-
if (fdls_get_state(fabric) > FDLS_STATE_FABRIC_FLOGI) {
4659-
if ((iport->fcid != d_id) || (!FNIC_FC_FRAME_CS_CTL(fchdr))) {
4660-
FNIC_FCS_DBG(KERN_INFO, fnic->host, fnic->fnic_num,
4661-
"invalid frame received. Dropping frame");
4662-
return -1;
4663-
}
4658+
if (fdls_get_state(fabric) > FDLS_STATE_FABRIC_FLOGI) {
4659+
if (iport->fcid != d_id || (!FNIC_FC_FRAME_CS_CTL(fchdr))) {
4660+
FNIC_FCS_DBG(KERN_INFO, fnic->host, fnic->fnic_num,
4661+
"invalid frame received. Dropping frame");
4662+
return -1;
46644663
}
4664+
}
46654665

46664666
/* BLS ABTS response */
46674667
if ((fchdr->fh_r_ctl == FC_RCTL_BA_ACC)
@@ -4678,7 +4678,7 @@ fnic_fdls_validate_and_get_frame_type(struct fnic_iport_s *iport,
46784678
"Received unexpected ABTS RSP(oxid:0x%x) from 0x%x. Dropping frame",
46794679
oxid, s_id);
46804680
return -1;
4681-
}
4681+
}
46824682
return FNIC_FABRIC_BLS_ABTS_RSP;
46834683
} else if (fdls_is_oxid_fdmi_req(oxid)) {
46844684
return FNIC_FDMI_BLS_ABTS_RSP;

0 commit comments

Comments
 (0)