Revert "wifi: mt76: Check link_conf pointer in mt76_connac_mcu_sta_basic_tlv()"

JIRA: https://issues.redhat.com/browse/RHEL-89168

commit f220374
Author: Lorenzo Bianconi <lorenzo@kernel.org>
Date:   Tue Mar 25 17:12:05 2025 +0100

    Revert "wifi: mt76: Check link_conf pointer in mt76_connac_mcu_sta_basic_tlv()"
    
    In mt76_connac_mcu_sta_basic_tlv() link_conf is always not NULL.
    Revert the commit '9890624c1b39 ("wifi: mt76: Check link_conf pointer in
    mt76_connac_mcu_sta_basic_tlv()")' in order to fix the following
    warning:
    
    drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c:394 mt76_connac_mcu_sta_basic_tlv()
    warn: variable dereferenced before check 'link_conf'
    
    This reverts commit 9890624.
    Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
    Link: https://patch.msgid.link/20250325-mt76_connac_mcu_sta_basic_tlv-link_conf-revert-v1-1-b84efefb74ee@kernel.org
    Signed-off-by: Felix Fietkau <nbd@nbd.name>

Signed-off-by: Jose Ignacio Tornos Martinez <jtornosm@redhat.com>

Author: jtornosm

drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c

@@ -391,7 +391,7 @@ void mt76_connac_mcu_sta_basic_tlv(struct mt76_dev *dev, struct sk_buff *skb,
 		basic->conn_type = cpu_to_le32(CONNECTION_INFRA_BC);
 
 		if (vif->type == NL80211_IFTYPE_STATION &&
-		    link_conf && !is_zero_ether_addr(link_conf->bssid)) {
+		    !is_zero_ether_addr(link_conf->bssid)) {
 			memcpy(basic->peer_addr, link_conf->bssid, ETH_ALEN);
 			basic->aid = cpu_to_le16(vif->cfg.aid);
 		} else {