HID: intel-thc-hid: Intel-quicki2c: Enhance driver re-install flow

Evenxf · Jiri Kosina · commit afa17a09c699 · 2025-08-13T13:55:38.000+02:00
After driver module is removed and during re-install stage, if there is continueous user touching on the screen, it is a risk impacting THC hardware initialization which causes driver installation failure. This patch enhances this flow by quiescing the external touch interrupt after driver is removed which keeps THC hardware ignore external interrupt during this remove and re-install stage. Signed-off-by: Even Xu <even.xu@intel.com> Tested-by: Rui Zhang <rui1.zhang@intel.com> Fixes: 66b59bf ("HID: intel-thc-hid: intel-quicki2c: Complete THC QuickI2C driver") Signed-off-by: Jiri Kosina <jkosina@suse.com>
diff --git a/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c b/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c
@@ -419,6 +419,7 @@ static struct quicki2c_device *quicki2c_dev_init(struct pci_dev *pdev, void __io
  */
 static void quicki2c_dev_deinit(struct quicki2c_device *qcdev)
 {
+	thc_interrupt_quiesce(qcdev->thc_hw, true);
 	thc_interrupt_enable(qcdev->thc_hw, false);
 	thc_ltr_unconfig(qcdev->thc_hw);
 	thc_wot_unconfig(qcdev->thc_hw);

Original file line number	Diff line number	Diff line change
`@@ -419,6 +419,7 @@ static struct quicki2c_device quicki2c_dev_init(struct pci_dev pdev, void __io`
`419`	`419`	`*/`
`420`	`420`	`static void quicki2c_dev_deinit(struct quicki2c_device *qcdev)`
`421`	`421`	`{`
	`422`	`+ thc_interrupt_quiesce(qcdev->thc_hw, true);`
`422`	`423`	`thc_interrupt_enable(qcdev->thc_hw, false);`
`423`	`424`	`thc_ltr_unconfig(qcdev->thc_hw);`
`424`	`425`	`thc_wot_unconfig(qcdev->thc_hw);`