Skip to content

Commit ae4a207

Browse files
committed
igb: cope with large MAX_SKB_FRAGS
jira LE-2974 Rebuild_History Non-Buildable kernel-5.14.0-503.40.1.el9_5 commit-author Paolo Abeni <pabeni@redhat.com> commit 8aba27c Sabrina reports that the igb driver does not cope well with large MAX_SKB_FRAG values: setting MAX_SKB_FRAG to 45 causes payload corruption on TX. An easy reproducer is to run ssh to connect to the machine. With MAX_SKB_FRAGS=17 it works, with MAX_SKB_FRAGS=45 it fails. This has been reported originally in https://bugzilla.redhat.com/show_bug.cgi?id=2265320 The root cause of the issue is that the driver does not take into account properly the (possibly large) shared info size when selecting the ring layout, and will try to fit two packets inside the same 4K page even when the 1st fraglist will trump over the 2nd head. Address the issue by checking if 2K buffers are insufficient. Fixes: 3948b05 ("net: introduce a config option to tweak MAX_SKB_FRAGS") Reported-by: Jan Tluka <jtluka@redhat.com> Reported-by: Jirka Hladky <jhladky@redhat.com> Reported-by: Sabrina Dubroca <sd@queasysnail.net> Tested-by: Sabrina Dubroca <sd@queasysnail.net> Tested-by: Corinna Vinschen <vinschen@redhat.com> Signed-off-by: Paolo Abeni <pabeni@redhat.com> Signed-off-by: Corinna Vinschen <vinschen@redhat.com> Link: https://patch.msgid.link/20240816152034.1453285-1-vinschen@redhat.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> (cherry picked from commit 8aba27c) Signed-off-by: Jonathan Maple <jmaple@ciq.com>
1 parent 4999bb9 commit ae4a207

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/net/ethernet/intel/igb/igb_main.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4806,6 +4806,7 @@ static void igb_set_rx_buffer_len(struct igb_adapter *adapter,
48064806

48074807
#if (PAGE_SIZE < 8192)
48084808
if (adapter->max_frame_size > IGB_MAX_FRAME_BUILD_SKB ||
4809+
IGB_2K_TOO_SMALL_WITH_PADDING ||
48094810
rd32(E1000_RCTL) & E1000_RCTL_SBP)
48104811
set_ring_uses_large_buffer(rx_ring);
48114812
#endif

0 commit comments

Comments
 (0)