Skip to content

Commit aa15f38

Browse files
skotur-brcmgregkh
authored andcommitted
bnxt_en: Add missing skb_mark_for_recycle() in bnxt_rx_vlan()
[ Upstream commit a63db07 ] If bnxt_rx_vlan() fails because the VLAN protocol ID is invalid, the SKB is freed but we're missing the call to recycle it. This may cause the warning: "page_pool_release_retry() stalled pool shutdown" Add the missing skb_mark_for_recycle() in bnxt_rx_vlan(). Fixes: 86b0550 ("bnxt_en: Use the unified RX page pool buffers for XDP and non-XDP") Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com> Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com> Signed-off-by: Michael Chan <michael.chan@broadcom.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 808a730 commit aa15f38

File tree

1 file changed

+1
-0
lines changed
  • drivers/net/ethernet/broadcom/bnxt

1 file changed

+1
-0
lines changed

drivers/net/ethernet/broadcom/bnxt/bnxt.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1986,6 +1986,7 @@ static struct sk_buff *bnxt_rx_vlan(struct sk_buff *skb, u8 cmp_type,
19861986
}
19871987
return skb;
19881988
vlan_err:
1989+
skb_mark_for_recycle(skb);
19891990
dev_kfree_skb(skb);
19901991
return NULL;
19911992
}

0 commit comments

Comments
 (0)