Skip to content

Commit a6f7828

Browse files
committed
sched/fair: Remove stale FREQUENCY_UTIL comment
JIRA: https://issues.redhat.com/browse/RHEL-48226 commit 7cb7fb5 Author: Christian Loehle <christian.loehle@arm.com> Date: Tue Mar 5 15:18:20 2024 +0000 sched/fair: Remove stale FREQUENCY_UTIL comment On 05/03/2024 15:05, Vincent Guittot wrote: I'm fine with either and that was my first thought here, too, but it did seem like the comment was mostly placed there to justify the 'unexpected' high utilization when explicitly passing FREQUENCY_UTIL and the need to clamp it then. So removing did feel slightly more natural to me anyway. So alternatively: From: Christian Loehle <christian.loehle@arm.com> Date: Tue, 5 Mar 2024 09:34:41 +0000 Subject: [PATCH] sched/fair: Remove stale FREQUENCY_UTIL mention effective_cpu_util() flags were removed, so remove mentioning of the flag. commit 9c0b4bb ("sched/cpufreq: Rework schedutil governor performance estimation") reworked effective_cpu_util() removing enum cpu_util_type. Modify the comment accordingly. Signed-off-by: Christian Loehle <christian.loehle@arm.com> Signed-off-by: Ingo Molnar <mingo@kernel.org> Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org> Link: https://lore.kernel.org/r/0e2833ee-0939-44e0-82a2-520a585a0153@arm.com Signed-off-by: Phil Auld <pauld@redhat.com>
1 parent 3a06ac6 commit a6f7828

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

kernel/sched/fair.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7659,8 +7659,8 @@ eenv_pd_max_util(struct energy_env *eenv, struct cpumask *pd_cpus,
76597659
* Performance domain frequency: utilization clamping
76607660
* must be considered since it affects the selection
76617661
* of the performance domain frequency.
7662-
* NOTE: in case RT tasks are running, by default the
7663-
* FREQUENCY_UTIL's utilization can be max OPP.
7662+
* NOTE: in case RT tasks are running, by default the min
7663+
* utilization can be max OPP.
76647664
*/
76657665
eff_util = effective_cpu_util(cpu, util, &min, &max);
76667666

0 commit comments

Comments
 (0)