Skip to content

Commit a643abb

Browse files
Liao Yuanhonglumag
authored andcommitted
drm/msm/mdp4: remove the use of dev_err_probe()
Logging messages that show some type of "out of memory" error are generally unnecessary as there is a generic message and a stack dump done by the memory subsystem. These messages generally increase kernel size without much added value[1]. The dev_err_probe() doesn't do anything when error is '-ENOMEM'. Therefore, remove the useless call to dev_err_probe(), and just return the value instead. [1]: https://lore.kernel.org/lkml/1402419340.30479.18.camel@joe-AO725/ Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> Patchwork: https://patchwork.freedesktop.org/patch/670017/ Link: https://lore.kernel.org/r/20250820131300.499727-1-liaoyuanhong@vivo.com Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
1 parent 88ec0e0 commit a643abb

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -512,7 +512,7 @@ static int mdp4_probe(struct platform_device *pdev)
512512

513513
mdp4_kms = devm_kzalloc(dev, sizeof(*mdp4_kms), GFP_KERNEL);
514514
if (!mdp4_kms)
515-
return dev_err_probe(dev, -ENOMEM, "failed to allocate kms\n");
515+
return -ENOMEM;
516516

517517
mdp4_kms->mmio = msm_ioremap(pdev, NULL);
518518
if (IS_ERR(mdp4_kms->mmio))

0 commit comments

Comments
 (0)