Skip to content

Commit a302379

Browse files
committed
Merge: cxgb4: Avoid removal of uninserted tid
MR: https://gitlab.com/redhat/rhel/src/kernel/rhel-10/-/merge_requests/303 JIRA: https://issues.redhat.com/browse/RHEL-75570 commit 4c12245 Author: Anumula Murali Mohan Reddy <anumula@chelsio.com> Date: Fri Jan 3 14:53:27 2025 +0530 cxgb4: Avoid removal of uninserted tid During ARP failure, tid is not inserted but _c4iw_free_ep() attempts to remove tid which results in error. This patch fixes the issue by avoiding removal of uninserted tid. Fixes: 59437d7 ("cxgb4/chtls: fix ULD connection failures due to wrong TID base") Signed-off-by: Anumula Murali Mohan Reddy <anumula@chelsio.com> Signed-off-by: Potnuri Bharat Teja <bharat@chelsio.com> Link: https://patch.msgid.link/20250103092327.1011925-1-anumula@chelsio.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Jakub Ramaseuski <jramaseu@redhat.com> Closes RHEL-75570 Approved-by: Michal Schmidt <mschmidt@redhat.com> Approved-by: Murphy Zhou <xzhou@redhat.com> Approved-by: Kamal Heib <kheib@redhat.com> Approved-by: CKI KWF Bot <cki-ci-bot+kwf-gitlab-com@redhat.com> Merged-by: Jan Stancek <jstancek@redhat.com>
2 parents cb31f8d + 0b41c3c commit a302379

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1799,7 +1799,10 @@ void cxgb4_remove_tid(struct tid_info *t, unsigned int chan, unsigned int tid,
17991799
struct adapter *adap = container_of(t, struct adapter, tids);
18001800
struct sk_buff *skb;
18011801

1802-
WARN_ON(tid_out_of_range(&adap->tids, tid));
1802+
if (tid_out_of_range(&adap->tids, tid)) {
1803+
dev_err(adap->pdev_dev, "tid %d out of range\n", tid);
1804+
return;
1805+
}
18031806

18041807
if (t->tid_tab[tid - adap->tids.tid_base]) {
18051808
t->tid_tab[tid - adap->tids.tid_base] = NULL;

0 commit comments

Comments
 (0)