Skip to content

Commit a0d4715

Browse files
committed
firmware: cs_dsp: test_bin_error: Use same test cases for adsp2 and Halo Core
JIRA: https://issues.redhat.com/browse/RHEL-80677 commit 2e2f89b Author: Richard Fitzgerald <rf@opensource.cirrus.com> Date: Wed Feb 19 15:21:32 2025 +0000 firmware: cs_dsp: test_bin_error: Use same test cases for adsp2 and Halo Core Re-use the adsp2 test cases for the Halo Core test run. Before this the Halo Core kunit_case array was an empty placeholder. Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com> Link: https://patch.msgid.link/20250219152132.1285941-1-rf@opensource.cirrus.com Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Jaroslav Kysela <jkysela@redhat.com>
1 parent 4793453 commit a0d4715

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

drivers/firmware/cirrus/test/cs_dsp_test_bin_error.c

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -534,11 +534,6 @@ static int cs_dsp_bin_err_test_adsp2_16bit_init(struct kunit *test)
534534
return cs_dsp_bin_err_test_common_init(test, dsp, 1);
535535
}
536536

537-
static struct kunit_case cs_dsp_bin_err_test_cases_halo[] = {
538-
539-
{ } /* terminator */
540-
};
541-
542537
static void cs_dsp_bin_err_block_types_desc(const struct cs_dsp_bin_test_param *param,
543538
char *desc)
544539
{
@@ -560,7 +555,7 @@ KUNIT_ARRAY_PARAM(bin_test_block_types,
560555
bin_test_block_types_cases,
561556
cs_dsp_bin_err_block_types_desc);
562557

563-
static struct kunit_case cs_dsp_bin_err_test_cases_adsp2[] = {
558+
static struct kunit_case cs_dsp_bin_err_test_cases[] = {
564559
KUNIT_CASE(bin_load_with_unknown_blocks),
565560
KUNIT_CASE(bin_err_wrong_magic),
566561
KUNIT_CASE(bin_err_too_short_for_header),
@@ -578,21 +573,21 @@ static struct kunit_suite cs_dsp_bin_err_test_halo = {
578573
.name = "cs_dsp_bin_err_halo",
579574
.init = cs_dsp_bin_err_test_halo_init,
580575
.exit = cs_dsp_bin_err_test_exit,
581-
.test_cases = cs_dsp_bin_err_test_cases_halo,
576+
.test_cases = cs_dsp_bin_err_test_cases,
582577
};
583578

584579
static struct kunit_suite cs_dsp_bin_err_test_adsp2_32bit = {
585580
.name = "cs_dsp_bin_err_adsp2_32bit",
586581
.init = cs_dsp_bin_err_test_adsp2_32bit_init,
587582
.exit = cs_dsp_bin_err_test_exit,
588-
.test_cases = cs_dsp_bin_err_test_cases_adsp2,
583+
.test_cases = cs_dsp_bin_err_test_cases,
589584
};
590585

591586
static struct kunit_suite cs_dsp_bin_err_test_adsp2_16bit = {
592587
.name = "cs_dsp_bin_err_adsp2_16bit",
593588
.init = cs_dsp_bin_err_test_adsp2_16bit_init,
594589
.exit = cs_dsp_bin_err_test_exit,
595-
.test_cases = cs_dsp_bin_err_test_cases_adsp2,
590+
.test_cases = cs_dsp_bin_err_test_cases,
596591
};
597592

598593
kunit_test_suites(&cs_dsp_bin_err_test_halo,

0 commit comments

Comments
 (0)