scsi: st: Fix array overflow in st_setup()

kmakisara · martinkpetersen · commit a018d1cf990d · 2025-03-17T22:04:21.000-04:00
Change the array size to follow parms size instead of a fixed value. Reported-by: Chenyuan Yang <chenyuan0y@gmail.com> Closes: https://lore.kernel.org/linux-scsi/CALGdzuoubbra4xKOJcsyThdk5Y1BrAmZs==wbqjbkAgmKS39Aw@mail.gmail.com/ Signed-off-by: Kai Mäkisara <Kai.Makisara@kolumbus.fi> Link: https://lore.kernel.org/r/20250311112516.5548-2-Kai.Makisara@kolumbus.fi Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c
@@ -4157,7 +4157,7 @@ static void validate_options(void)
  */
 static int __init st_setup(char *str)
 {
-	int i, len, ints[5];
+	int i, len, ints[ARRAY_SIZE(parms) + 1];
 	char *stp;
 
 	stp = get_options(str, ARRAY_SIZE(ints), ints);

Original file line number	Diff line number	Diff line change
`@@ -4157,7 +4157,7 @@ static void validate_options(void)`
`4157`	`4157`	`*/`
`4158`	`4158`	`static int __init st_setup(char *str)`
`4159`	`4159`	`{`
`4160`		`- int i, len, ints[5];`
	`4160`	`+ int i, len, ints[ARRAY_SIZE(parms) + 1];`
`4161`	`4161`	`char *stp;`
`4162`	`4162`
`4163`	`4163`	`stp = get_options(str, ARRAY_SIZE(ints), ints);`