Skip to content

Commit 9f3b2e4

Browse files
Łukasz Bartosikgregkh
authored andcommitted
xhci: dbctty: disable ECHO flag by default
commit 2b857d6 upstream. When /dev/ttyDBC0 device is created then by default ECHO flag is set for the terminal device. However if data arrives from a peer before application using /dev/ttyDBC0 applies its set of terminal flags then the arriving data will be echoed which might not be desired behavior. Fixes: 4521f16 ("xhci: dbctty: split dbc tty driver registration and unregistration functions.") Cc: stable <stable@kernel.org> Signed-off-by: Łukasz Bartosik <ukaszb@chromium.org> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com> Link: https://lore.kernel.org/stable/20250610111802.18742-1-ukaszb%40chromium.org Link: https://lore.kernel.org/r/20250627144127.3889714-4-mathias.nyman@linux.intel.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent fbebc22 commit 9f3b2e4

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/usb/host/xhci-dbgtty.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -585,6 +585,7 @@ int dbc_tty_init(void)
585585
dbc_tty_driver->type = TTY_DRIVER_TYPE_SERIAL;
586586
dbc_tty_driver->subtype = SERIAL_TYPE_NORMAL;
587587
dbc_tty_driver->init_termios = tty_std_termios;
588+
dbc_tty_driver->init_termios.c_lflag &= ~ECHO;
588589
dbc_tty_driver->init_termios.c_cflag =
589590
B9600 | CS8 | CREAD | HUPCL | CLOCAL;
590591
dbc_tty_driver->init_termios.c_ispeed = 9600;

0 commit comments

Comments
 (0)