media: saa6752hs: Don't set format in sub-device state

JIRA: https://issues.redhat.com/browse/RHEL-86821

commit c692696
Author: Sakari Ailus <sakari.ailus@linux.intel.com>
Date:   Wed Dec 6 13:35:33 2023 +0200

  For the purpose of setting old non-pad based sub-device try format as a
  basis for VIDIOC_TRY_FMT implementation, there is no need to set the
  format in the sub-device state. Drop the assignment to the state, which
  would result in a NULL pointer dereference.

  Fixes: fd17e3a ("media: i2c: Use accessors for pad config 'try_*' fields")
  Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
  Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
  Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

Signed-off-by: Kate Hsuan <hpa@redhat.com>

Author: Kate Hsuan

drivers/media/i2c/saa6752hs.c

@@ -594,10 +594,8 @@ static int saa6752hs_set_fmt(struct v4l2_subdev *sd,
 	f->field = V4L2_FIELD_INTERLACED;
 	f->colorspace = V4L2_COLORSPACE_SMPTE170M;
 
-	if (format->which == V4L2_SUBDEV_FORMAT_TRY) {
-		*v4l2_subdev_get_pad_format(sd, sd_state, 0) = *f;
+	if (format->which == V4L2_SUBDEV_FORMAT_TRY)
 		return 0;
-	}
 
 	/*
 	  FIXME: translate and round width/height into EMPRESS