Skip to content

Commit 9b05549

Browse files
committed
i2c: i801: remove printout on handled timeouts
JIRA: https://issues.redhat.com/browse/RHEL-47426 commit b757eb0 Author: Wolfram Sang <wsa+renesas@sang-engineering.com> Date: Tue Apr 23 14:13:18 2024 +0200 i2c: i801: remove printout on handled timeouts I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout and turn the SMBus-specific termination message to debug. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Jean Delvare <jdelvare@suse.de> Signed-off-by: Andi Shyti <andi.shyti@kernel.org> Signed-off-by: David Arcari <darcari@redhat.com>
1 parent a8d0753 commit 9b05549

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

drivers/i2c/busses/i2c-i801.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -401,9 +401,7 @@ static int i801_check_post(struct i801_priv *priv, int status)
401401
* If the SMBus is still busy, we give up
402402
*/
403403
if (unlikely(status < 0)) {
404-
dev_err(&priv->pci_dev->dev, "Transaction timeout\n");
405404
/* try to stop the current command */
406-
dev_dbg(&priv->pci_dev->dev, "Terminating the current operation\n");
407405
outb_p(SMBHSTCNT_KILL, SMBHSTCNT(priv));
408406
usleep_range(1000, 2000);
409407
outb_p(0, SMBHSTCNT(priv));
@@ -412,7 +410,7 @@ static int i801_check_post(struct i801_priv *priv, int status)
412410
status = inb_p(SMBHSTSTS(priv));
413411
if ((status & SMBHSTSTS_HOST_BUSY) ||
414412
!(status & SMBHSTSTS_FAILED))
415-
dev_err(&priv->pci_dev->dev,
413+
dev_dbg(&priv->pci_dev->dev,
416414
"Failed terminating the transaction\n");
417415
return -ETIMEDOUT;
418416
}

0 commit comments

Comments
 (0)