thermal: testing: Simplify tt_get_tt_zone()

rafaeljw · rafaeljw · commit 9782dd101f34 · 2024-11-12T21:47:18.000+01:00
Notice that tt_get_tt_zone() need not use the ret variable in the tt_thermal_zones list walk and make it return right after incrementing the reference counter of the matching entry. No functional impact. Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Link: https://patch.msgid.link/6120304.lOV4Wx5bFT@rjwysocki.net
diff --git a/drivers/thermal/testing/zone.c b/drivers/thermal/testing/zone.c
@@ -288,19 +288,14 @@ static struct tt_thermal_zone *tt_get_tt_zone(const char *arg)
 
 	guard(mutex)(&tt_thermal_zones_lock);
 
-	ret = -EINVAL;
 	list_for_each_entry(tt_zone, &tt_thermal_zones, list_node) {
 		if (tt_zone->id == id) {
 			tt_zone->refcount++;
-			ret = 0;
-			break;
+			return tt_zone;
 		}
 	}
 
-	if (ret)
-		return ERR_PTR(ret);
-
-	return tt_zone;
+	return ERR_PTR(-EINVAL);
 }
 
 static void tt_put_tt_zone(struct tt_thermal_zone *tt_zone)

Original file line number	Diff line number	Diff line change
`@@ -288,19 +288,14 @@ static struct tt_thermal_zone tt_get_tt_zone(const char arg)`
`288`	`288`
`289`	`289`	`guard(mutex)(&tt_thermal_zones_lock);`
`290`	`290`
`291`		`- ret = -EINVAL;`
`292`	`291`	`list_for_each_entry(tt_zone, &tt_thermal_zones, list_node) {`
`293`	`292`	`if (tt_zone->id == id) {`
`294`	`293`	`tt_zone->refcount++;`
`295`		`- ret = 0;`
`296`		`- break;`
	`294`	`+ return tt_zone;`
`297`	`295`	`}`
`298`	`296`	`}`
`299`	`297`
`300`		`- if (ret)`
`301`		`- return ERR_PTR(ret);`
`302`		`-`
`303`		`- return tt_zone;`
	`298`	`+ return ERR_PTR(-EINVAL);`
`304`	`299`	`}`
`305`	`300`
`306`	`301`	`static void tt_put_tt_zone(struct tt_thermal_zone *tt_zone)`