Skip to content

Commit 97771b7

Browse files
committed
bnxt_en: Adjust logging of firmware messages in case of released token in __hwrm_send()
jira LE-2157 cve CVE-2024-40919 Rebuild_History Non-Buildable kernel-5.14.0-503.14.1.el9_5 commit-author Aleksandr Mishin <amishin@t-argos.ru> commit a9b9741 In case of token is released due to token->state == BNXT_HWRM_DEFERRED, released token (set to NULL) is used in log messages. This issue is expected to be prevented by HWRM_ERR_CODE_PF_UNAVAILABLE error code. But this error code is returned by recent firmware. So some firmware may not return it. This may lead to NULL pointer dereference. Adjust this issue by adding token pointer check. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 8fa4219 ("bnxt_en: add dynamic debug support for HWRM messages") Suggested-by: Michael Chan <michael.chan@broadcom.com> Signed-off-by: Aleksandr Mishin <amishin@t-argos.ru> Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com> Reviewed-by: Michael Chan <michael.chan@broadcom.com> Link: https://lore.kernel.org/r/20240611082547.12178-1-amishin@t-argos.ru Signed-off-by: Jakub Kicinski <kuba@kernel.org> (cherry picked from commit a9b9741) Signed-off-by: Jonathan Maple <jmaple@ciq.com>
1 parent 6aafa19 commit 97771b7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/ethernet/broadcom/bnxt/bnxt_hwrm.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -680,7 +680,7 @@ static int __hwrm_send(struct bnxt *bp, struct bnxt_hwrm_ctx *ctx)
680680
req_type);
681681
else if (rc && rc != HWRM_ERR_CODE_PF_UNAVAILABLE)
682682
hwrm_err(bp, ctx, "hwrm req_type 0x%x seq id 0x%x error 0x%x\n",
683-
req_type, token->seq_id, rc);
683+
req_type, le16_to_cpu(ctx->req->seq_id), rc);
684684
rc = __hwrm_to_stderr(rc);
685685
exit:
686686
if (token)

0 commit comments

Comments
 (0)