Skip to content

Commit 8dab28e

Browse files
committed
HID: wacom: fix memory leak on sysfs attribute creation failure
JIRA: https://issues.redhat.com/browse/RHEL-102058 Upstream Status: v6.16 commit 1a19ae4 Author: Qasim Ijaz <qasdev00@gmail.com> Date: Fri Jun 6 19:49:58 2025 +0100 HID: wacom: fix memory leak on sysfs attribute creation failure When sysfs_create_files() fails during wacom_initialize_remotes() the fifo buffer is not freed leading to a memory leak. Fix this by calling kfifo_free() before returning. Fixes: 83e6b40 ("HID: wacom: EKR: have the wacom resources dynamically allocated") Reviewed-by: Ping Cheng <ping.cheng@wacom.com> Cc: stable@vger.kernel.org Signed-off-by: Qasim Ijaz <qasdev00@gmail.com> Signed-off-by: Jiri Kosina <jkosina@suse.com> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
1 parent 5dcaa73 commit 8dab28e

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/hid/wacom_sys.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2056,6 +2056,7 @@ static int wacom_initialize_remotes(struct wacom *wacom)
20562056
if (error) {
20572057
hid_err(wacom->hdev,
20582058
"cannot create sysfs group err: %d\n", error);
2059+
kfifo_free(&remote->remote_fifo);
20592060
return error;
20602061
}
20612062

0 commit comments

Comments
 (0)