rtc: optee: fix error code in probe()

Dan Carpenter · alexandrebelloni · commit 8bbd727453b4 · 2025-10-05T20:52:40.000+02:00
Return an error code if kthread_create() fails. Currently the code returns success. Fixes: 6266aea ("rtc: optee: add alarm related rtc ops to optee rtc driver") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Link: https://lore.kernel.org/r/21f1a18008f1bbc8f70d0bd5c05b72fbf5fc9c7d.1758182509.git.dan.carpenter@linaro.org Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
diff --git a/drivers/rtc/rtc-optee.c b/drivers/rtc/rtc-optee.c
@@ -614,6 +614,7 @@ static int optee_rtc_probe(struct device *dev)
 						  priv, "rtc_alarm_evt");
 		if (IS_ERR(priv->alarm_task)) {
 			dev_err(dev, "Failed to create alarm thread\n");
+			err = PTR_ERR(priv->alarm_task);
 			goto out_shm;
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -614,6 +614,7 @@ static int optee_rtc_probe(struct device *dev)`
`614`	`614`	`priv, "rtc_alarm_evt");`
`615`	`615`	`if (IS_ERR(priv->alarm_task)) {`
`616`	`616`	`dev_err(dev, "Failed to create alarm thread\n");`
	`617`	`+ err = PTR_ERR(priv->alarm_task);`
`617`	`618`	`goto out_shm;`
`618`	`619`	`}`
`619`	`620`