Skip to content

Commit 89270f3

Browse files
author
Sabrina Dubroca
committed
selftests: tls: test TCP stealing data from under the TLS socket
JIRA: https://issues.redhat.com/browse/RHEL-115640 Conflicts: tls_crypto_info_init doesn't take the final argument commit d7e8259 Author: Jakub Kicinski <kuba@kernel.org> Date: Thu Aug 7 16:29:07 2025 -0700 selftests: tls: test TCP stealing data from under the TLS socket Check a race where data disappears from the TCP socket after TLS signaled that its ready to receive. ok 6 global.data_steal # RUN tls_basic.base_base ... # OK tls_basic.base_base Reviewed-by: Eric Dumazet <edumazet@google.com> Link: https://patch.msgid.link/20250807232907.600366-2-kuba@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sabrina Dubroca <sdubroca@redhat.com>
1 parent bb0e0fd commit 89270f3

File tree

1 file changed

+63
-0
lines changed
  • tools/testing/selftests/net

1 file changed

+63
-0
lines changed

tools/testing/selftests/net/tls.c

Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2486,6 +2486,69 @@ TEST(prequeue) {
24862486
close(cfd);
24872487
}
24882488

2489+
TEST(data_steal) {
2490+
struct tls_crypto_info_keys tls;
2491+
char buf[20000], buf2[20000];
2492+
struct sockaddr_in addr;
2493+
int sfd, cfd, ret, fd;
2494+
int pid, status;
2495+
socklen_t len;
2496+
2497+
len = sizeof(addr);
2498+
memrnd(buf, sizeof(buf));
2499+
2500+
tls_crypto_info_init(TLS_1_2_VERSION, TLS_CIPHER_AES_GCM_256, &tls);
2501+
2502+
addr.sin_family = AF_INET;
2503+
addr.sin_addr.s_addr = htonl(INADDR_ANY);
2504+
addr.sin_port = 0;
2505+
2506+
fd = socket(AF_INET, SOCK_STREAM, 0);
2507+
sfd = socket(AF_INET, SOCK_STREAM, 0);
2508+
2509+
ASSERT_EQ(bind(sfd, &addr, sizeof(addr)), 0);
2510+
ASSERT_EQ(listen(sfd, 10), 0);
2511+
ASSERT_EQ(getsockname(sfd, &addr, &len), 0);
2512+
ASSERT_EQ(connect(fd, &addr, sizeof(addr)), 0);
2513+
ASSERT_GE(cfd = accept(sfd, &addr, &len), 0);
2514+
close(sfd);
2515+
2516+
ret = setsockopt(fd, IPPROTO_TCP, TCP_ULP, "tls", sizeof("tls"));
2517+
if (ret) {
2518+
ASSERT_EQ(errno, ENOENT);
2519+
SKIP(return, "no TLS support");
2520+
}
2521+
ASSERT_EQ(setsockopt(cfd, IPPROTO_TCP, TCP_ULP, "tls", sizeof("tls")), 0);
2522+
2523+
/* Spawn a child and get it into the read wait path of the underlying
2524+
* TCP socket.
2525+
*/
2526+
pid = fork();
2527+
ASSERT_GE(pid, 0);
2528+
if (!pid) {
2529+
EXPECT_EQ(recv(cfd, buf, sizeof(buf), MSG_WAITALL),
2530+
sizeof(buf));
2531+
exit(!__test_passed(_metadata));
2532+
}
2533+
2534+
usleep(2000);
2535+
ASSERT_EQ(setsockopt(fd, SOL_TLS, TLS_TX, &tls, tls.len), 0);
2536+
ASSERT_EQ(setsockopt(cfd, SOL_TLS, TLS_RX, &tls, tls.len), 0);
2537+
2538+
EXPECT_EQ(send(fd, buf, sizeof(buf), 0), sizeof(buf));
2539+
usleep(2000);
2540+
EXPECT_EQ(recv(cfd, buf2, sizeof(buf2), MSG_DONTWAIT), -1);
2541+
/* Don't check errno, the error will be different depending
2542+
* on what random bytes TLS interpreted as the record length.
2543+
*/
2544+
2545+
close(fd);
2546+
close(cfd);
2547+
2548+
EXPECT_EQ(wait(&status), pid);
2549+
EXPECT_EQ(status, 0);
2550+
}
2551+
24892552
static void __attribute__((constructor)) fips_check(void) {
24902553
int res;
24912554
FILE *f;

0 commit comments

Comments
 (0)