Skip to content

Commit 8337204

Browse files
author
Peter Zijlstra
committed
futex: Handle invalid node numbers supplied by user
syzbot used a negative node number which was not rejected early and led to invalid memory access in node_possible(). Reject negative node numbers except for FUTEX_NO_NODE. [bigeasy: Keep the FUTEX_NO_NODE check] Closes: https://lore.kernel.org/all/6835bfe3.a70a0220.253bc2.00b5.GAE@google.com/ Fixes: cec199c ("futex: Implement FUTEX2_NUMA") Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Reported-by: syzbot+9afaf6749e3a7aa1bdf3@syzkaller.appspotmail.com Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Link: https://lkml.kernel.org/r/20250528085521.1938355-4-bigeasy@linutronix.de
1 parent 0ecb423 commit 8337204

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

kernel/futex/core.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -583,8 +583,8 @@ int get_futex_key(u32 __user *uaddr, unsigned int flags, union futex_key *key,
583583
if (futex_get_value(&node, naddr))
584584
return -EFAULT;
585585

586-
if (node != FUTEX_NO_NODE &&
587-
(node >= MAX_NUMNODES || !node_possible(node)))
586+
if ((node != FUTEX_NO_NODE) &&
587+
((unsigned int)node >= MAX_NUMNODES || !node_possible(node)))
588588
return -EINVAL;
589589
}
590590

0 commit comments

Comments
 (0)