fbdev: efifb: Change the return value type to void

Jocelyn Falempe · Jocelyn Falempe · commit 7fd84e57379c · 2025-04-29T10:04:41.000+02:00
JIRA: https://issues.redhat.com/browse/RHEL-75953 Upstream Status: v6.14-rc1 commit 021e111 Author: Shixiong Ou <oushixiong@kylinos.cn> AuthorDate: Fri Jan 3 11:26:33 2025 +0800 Commit: Helge Deller <deller@gmx.de> CommitDate: Thu Jan 9 00:29:42 2025 +0100 efifb_setup() doesn't need to return a value. Signed-off-by: Shixiong Ou <oushixiong@kylinos.cn> Signed-off-by: Helge Deller <deller@gmx.de> Signed-off-by: Jocelyn Falempe <jfalempe@redhat.com>
diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c
@@ -275,7 +275,7 @@ static const struct fb_ops efifb_ops = {
 	.fb_setcolreg	= efifb_setcolreg,
 };
 
-static int efifb_setup(struct screen_info *si, char *options)
+static void efifb_setup(struct screen_info *si, char *options)
 {
 	char *this_opt;
 
@@ -299,8 +299,6 @@ static int efifb_setup(struct screen_info *si, char *options)
 				use_bgrt = false;
 		}
 	}
-
-	return 0;
 }
 
 static inline bool fb_base_is_valid(struct screen_info *si)

Original file line number	Diff line number	Diff line change
`@@ -275,7 +275,7 @@ static const struct fb_ops efifb_ops = {`
`275`	`275`	`.fb_setcolreg = efifb_setcolreg,`
`276`	`276`	`};`
`277`	`277`
`278`		`-static int efifb_setup(struct screen_info si, char options)`
	`278`	`+static void efifb_setup(struct screen_info si, char options)`
`279`	`279`	`{`
`280`	`280`	`char *this_opt;`
`281`	`281`
`@@ -299,8 +299,6 @@ static int efifb_setup(struct screen_info si, char options)`
`299`	`299`	`use_bgrt = false;`
`300`	`300`	`}`
`301`	`301`	`}`
`302`		`-`
`303`		`- return 0;`
`304`	`302`	`}`
`305`	`303`
`306`	`304`	`static inline bool fb_base_is_valid(struct screen_info *si)`