Skip to content

Commit 7dacee5

Browse files
committed
Merge: REDHAT: Makefile, dont reset dist-git-tmp if set
MR: https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9/-/merge_requests/4498 JIRA: internal This reverts my previous attempt at fixing this, and introduces a new fix. Makefile.rhpkg is called on each invocation of @$(MAKE), because of it, RHDISTGIT_TMP is being redefined to the default value after the first invocation. This fixes that by checking if the variable has already been set before redefining it. Signed-off-by: Lucas Zampieri <lzampier@redhat.com> Approved-by: Jan Stancek <jstancek@redhat.com> Approved-by: Patrick Talbert <ptalbert@redhat.com> Approved-by: Bruno Meneguele <bmeneg@redhat.com> Approved-by: John Pittman <jpittman@redhat.com> Merged-by: Lucas Zampieri <lzampier@redhat.com>
2 parents 58035f8 + 0562bed commit 7dacee5

25 files changed

+1
-27
lines changed

redhat/Makefile.rhpkg

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,7 @@ endif
1919
#RHDISTGIT_CACHE:=
2020
# Temporary directory to clone the dist-git repo to. Change this if you
2121
# have a faster storage
22-
ifndef RHDISTGIT_TMP
23-
RHDISTGIT_TMP:=/tmp
24-
endif
22+
RHDISTGIT_TMP?=/tmp
2523

2624
# load configuration, starting with home directory then local
2725
ifeq ("$(RHDISTGIT_CACHE)", "")

redhat/self-test/data/centos-6161a435c191.el7

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ PROCESS_CONFIGS_OPTS=-n -w -c
4646
REDHAT=../redhat
4747
RELEASETAG=kernel-5.12.0-0.rc4.6.test
4848
RHDISTGIT_BRANCH=c9s
49-
RHDISTGIT_TMP=/tmp
5049
RHDISTGIT_USER="shadowman"
5150
RHEL_MAJOR=9
5251
RHEL_MINOR=5

redhat/self-test/data/centos-6161a435c191.fc25

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ PROCESS_CONFIGS_OPTS=-n -w -c
4646
REDHAT=../redhat
4747
RELEASETAG=kernel-5.12.0-0.rc4.6.test
4848
RHDISTGIT_BRANCH=c9s
49-
RHDISTGIT_TMP=/tmp
5049
RHDISTGIT_USER="shadowman"
5150
RHEL_MAJOR=9
5251
RHEL_MINOR=5

redhat/self-test/data/centos-9f4ad9e425a1.el7

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ PROCESS_CONFIGS_OPTS=-n -w -c
4646
REDHAT=../redhat
4747
RELEASETAG=kernel-5.12.0-6.test
4848
RHDISTGIT_BRANCH=c9s
49-
RHDISTGIT_TMP=/tmp
5049
RHDISTGIT_USER="shadowman"
5150
RHEL_MAJOR=9
5251
RHEL_MINOR=5

redhat/self-test/data/centos-9f4ad9e425a1.fc25

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ PROCESS_CONFIGS_OPTS=-n -w -c
4646
REDHAT=../redhat
4747
RELEASETAG=kernel-5.12.0-6.test
4848
RHDISTGIT_BRANCH=c9s
49-
RHDISTGIT_TMP=/tmp
5049
RHDISTGIT_USER="shadowman"
5150
RHEL_MAJOR=9
5251
RHEL_MINOR=5

redhat/self-test/data/centos-a5e13c6df0e4.el7

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ PROCESS_CONFIGS_OPTS=-n -w -c
4646
REDHAT=../redhat
4747
RELEASETAG=kernel-5.12.0-0.rc5.6.test
4848
RHDISTGIT_BRANCH=c9s
49-
RHDISTGIT_TMP=/tmp
5049
RHDISTGIT_USER="shadowman"
5150
RHEL_MAJOR=9
5251
RHEL_MINOR=5

redhat/self-test/data/centos-a5e13c6df0e4.fc25

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ PROCESS_CONFIGS_OPTS=-n -w -c
4646
REDHAT=../redhat
4747
RELEASETAG=kernel-5.12.0-0.rc5.6.test
4848
RHDISTGIT_BRANCH=c9s
49-
RHDISTGIT_TMP=/tmp
5049
RHDISTGIT_USER="shadowman"
5150
RHEL_MAJOR=9
5251
RHEL_MINOR=5

redhat/self-test/data/centos-edc9dd1e3c31.el7

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ PROCESS_CONFIGS_OPTS=-n -w -c
4646
REDHAT=../redhat
4747
RELEASETAG=kernel-5.12.0-6.test
4848
RHDISTGIT_BRANCH=c9s
49-
RHDISTGIT_TMP=/tmp
5049
RHDISTGIT_USER="shadowman"
5150
RHEL_MAJOR=9
5251
RHEL_MINOR=5

redhat/self-test/data/centos-edc9dd1e3c31.fc25

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ PROCESS_CONFIGS_OPTS=-n -w -c
4646
REDHAT=../redhat
4747
RELEASETAG=kernel-5.12.0-6.test
4848
RHDISTGIT_BRANCH=c9s
49-
RHDISTGIT_TMP=/tmp
5049
RHDISTGIT_USER="shadowman"
5150
RHEL_MAJOR=9
5251
RHEL_MINOR=5

redhat/self-test/data/fedora-6161a435c191.el7

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ PROCESS_CONFIGS_OPTS=-n -w -c
4646
REDHAT=../redhat
4747
RELEASETAG=kernel-5.12.0-0.rc4.6.test
4848
RHDISTGIT_BRANCH=rawhide
49-
RHDISTGIT_TMP=/tmp
5049
RHDISTGIT_USER="shadowman"
5150
RHEL_MAJOR=9
5251
RHEL_MINOR=5

0 commit comments

Comments
 (0)