ASoC: simple-card-utils: Don't use __free(device_node) at graph_util_parse_dai()

JIRA: https://issues.redhat.com/browse/RHEL-80682

CVE: CVE-2025-39930

commit de74ec7
Author: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Date: Fri Feb 28 00:29:30 2025 +0000

    ASoC: simple-card-utils: Don't use __free(device_node) at graph_util_parse_dai()

    commit 419d191 ("ASoC: simple-card-utils: use __free(device_node) for
    device node") uses __free(device_node) for dlc->of_node, but we need to
    keep it while driver is in use.

    Don't use __free(device_node) in graph_util_parse_dai().

    Fixes: 419d191 ("ASoC: simple-card-utils: use __free(device_node) for device node")
    Reported-by: Thuan Nguyen <thuan.nguyen-hong@banvien.com.vn>
    Reported-by: Detlev Casanova <detlev.casanova@collabora.com>
    Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
    Tested-by: Thuan Nguyen <thuan.nguyen-hong@banvien.com.vn>
    Tested-by: Detlev Casanova <detlev.casanova@collabora.com>
    Link: https://patch.msgid.link/87eczisyhh.wl-kuninori.morimoto.gx@renesas.com
    Signed-off-by: Mark Brown <broonie@kernel.org>

Signed-off-by: Jaroslav Kysela <jkysela@redhat.com>

Author: jkysela-rh

sound/soc/generic/simple-card-utils.c

@@ -1079,14 +1079,15 @@ static int graph_get_dai_id(struct device_node *ep)
 int graph_util_parse_dai(struct device *dev, struct device_node *ep,
 			 struct snd_soc_dai_link_component *dlc, int *is_single_link)
 {
+	struct device_node *node;
 	struct of_phandle_args args = {};
 	struct snd_soc_dai *dai;
 	int ret;
 
 	if (!ep)
 		return 0;
 
-	struct device_node *node __free(device_node) = of_graph_get_port_parent(ep);
+	node = of_graph_get_port_parent(ep);
 
 	/*
 	 * Try to find from DAI node
@@ -1128,8 +1129,10 @@ int graph_util_parse_dai(struct device *dev, struct device_node *ep,
 	 *    if he unbinded CPU or Codec.
 	 */
 	ret = snd_soc_get_dlc(&args, dlc);
-	if (ret < 0)
+	if (ret < 0) {
+		of_node_put(node);
 		return ret;
+	}
 
 parse_dai_end:
 	if (is_single_link)