Skip to content

Commit 75527d6

Browse files
Yi CongPaolo Abeni
authored andcommitted
r8152: add error handling in rtl8152_driver_init
rtl8152_driver_init() is missing the error handling. When rtl8152_driver registration fails, rtl8152_cfgselector_driver should be deregistered. Fixes: ec51fbd ("r8152: add USB device driver for config selection") Cc: stable@vger.kernel.org Signed-off-by: Yi Cong <yicong@kylinos.cn> Reviewed-by: Simon Horman <horms@kernel.org> Link: https://patch.msgid.link/20251011082415.580740-1-yicongsrfy@163.com [pabeni@redhat.com: clarified the commit message] Signed-off-by: Paolo Abeni <pabeni@redhat.com>
1 parent 327cd4b commit 75527d6

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

drivers/net/usb/r8152.c

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10122,7 +10122,12 @@ static int __init rtl8152_driver_init(void)
1012210122
ret = usb_register_device_driver(&rtl8152_cfgselector_driver, THIS_MODULE);
1012310123
if (ret)
1012410124
return ret;
10125-
return usb_register(&rtl8152_driver);
10125+
10126+
ret = usb_register(&rtl8152_driver);
10127+
if (ret)
10128+
usb_deregister_device_driver(&rtl8152_cfgselector_driver);
10129+
10130+
return ret;
1012610131
}
1012710132

1012810133
static void __exit rtl8152_driver_exit(void)

0 commit comments

Comments
 (0)