exec: Fix incorrect type for ret

Xichao Zhao · gregkh · commit 6b0a29257793 · 2025-10-29T14:08:51.000+01:00
[ Upstream commit 5e08824 ] In the setup_arg_pages(), ret is declared as an unsigned long. The ret might take a negative value. Therefore, its type should be changed to int. Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com> Reviewed-by: Jan Kara <jack@suse.cz> Link: https://lore.kernel.org/r/20250825073609.219855-1-zhao.xichao@vivo.com Signed-off-by: Kees Cook <kees@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
diff --git a/fs/exec.c b/fs/exec.c
@@ -717,7 +717,7 @@ int setup_arg_pages(struct linux_binprm *bprm,
 		    unsigned long stack_top,
 		    int executable_stack)
 {
-	unsigned long ret;
+	int ret;
 	unsigned long stack_shift;
 	struct mm_struct *mm = current->mm;
 	struct vm_area_struct *vma = bprm->vma;

Original file line number	Diff line number	Diff line change
`@@ -717,7 +717,7 @@ int setup_arg_pages(struct linux_binprm *bprm,`
`717`	`717`	`unsigned long stack_top,`
`718`	`718`	`int executable_stack)`
`719`	`719`	`{`
`720`		`- unsigned long ret;`
	`720`	`+ int ret;`
`721`	`721`	`unsigned long stack_shift;`
`722`	`722`	`struct mm_struct *mm = current->mm;`
`723`	`723`	`struct vm_area_struct *vma = bprm->vma;`