Skip to content

Commit 5f54134

Browse files
prabhakarladvinodkoul
authored andcommitted
phy: renesas: rcar-gen3-usb2: Move debug print after register value is updated
Relocate the debug print in rcar_gen3_enable_vbus_ctrl() to appear after the `val` variable is assigned and updated based on the VBUS state. This ensures that the debug log reflects the actual register value being written, improving debugging accuracy. Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> Link: https://lore.kernel.org/r/20250808215209.3692744-6-prabhakar.mahadev-lad.rj@bp.renesas.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
1 parent b725741 commit 5f54134

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/phy/renesas/phy-rcar-gen3-usb2.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,6 @@ static void rcar_gen3_enable_vbus_ctrl(struct rcar_gen3_chan *ch, int vbus)
211211
u32 vbus_ctrl_val = USB2_ADPCTRL_DRVVBUS;
212212
u32 val;
213213

214-
dev_vdbg(ch->dev, "%s: %08x, %d\n", __func__, val, vbus);
215214
if (ch->phy_data->no_adp_ctrl || ch->phy_data->vblvl_ctrl) {
216215
if (ch->vbus)
217216
regulator_hardware_enable(ch->vbus, vbus);
@@ -225,6 +224,7 @@ static void rcar_gen3_enable_vbus_ctrl(struct rcar_gen3_chan *ch, int vbus)
225224
val |= vbus_ctrl_val;
226225
else
227226
val &= ~vbus_ctrl_val;
227+
dev_vdbg(ch->dev, "%s: %08x, %d\n", __func__, val, vbus);
228228
writel(val, usb2_base + vbus_ctrl_reg);
229229
}
230230

0 commit comments

Comments
 (0)