nfsd: fix legacy client tracking initialization

JIRA: https://issues.redhat.com/browse/RHEL-108616

commit de71d4e
Author: Scott Mayhew <smayhew@redhat.com>
Date:   Tue Dec 10 07:25:54 2024 -0500

    nfsd: fix legacy client tracking initialization

    Get rid of the nfsd4_legacy_tracking_ops->init() call in
    check_for_legacy_methods().  That will be handled in the caller
    (nfsd4_client_tracking_init()).  Otherwise, we'll wind up calling
    nfsd4_legacy_tracking_ops->init() twice, and the second time we'll
    trigger the BUG_ON() in nfsd4_init_recdir().

    Fixes: 74fd487 ("nfsd: new Kconfig option for legacy client tracking")
    Reported-by: Jur van der Burg <jur@avtware.com>
    Link: https://bugzilla.kernel.org/show_bug.cgi?id=219580
    Signed-off-by: Scott Mayhew <smayhew@redhat.com>
    Reviewed-by: Jeff Layton <jlayton@kernel.org>
    Tested-by: Salvatore Bonaccorso <carnil@debian.org>
    Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

Signed-off-by: Benjamin Coddington <bcodding@redhat.com>

Author: bcodding-rh

fs/nfsd/nfs4recover.c

@@ -2055,7 +2055,6 @@ static inline int check_for_legacy_methods(int status, struct net *net)
 		path_put(&path);
 		if (status)
 			return -ENOTDIR;
-		status = nn->client_tracking_ops->init(net);
 	}
 	return status;
 }