x86/boot: Change some static bootflag functions to bool

ubizjak · Ingo Molnar · commit 5bebe2e4fe27 · 2025-02-22T12:30:59.000+01:00
The return values of some functions are of boolean type. Change the type of these function to bool and adjust their return values. No functional change intended. Signed-off-by: Uros Bizjak <ubizjak@gmail.com> Signed-off-by: Ingo Molnar <mingo@kernel.org> Link: https://lore.kernel.org/r/20250129154920.6773-1-ubizjak@gmail.com
diff --git a/arch/x86/kernel/bootflag.c b/arch/x86/kernel/bootflag.c
@@ -20,7 +20,7 @@
 
 int sbf_port __initdata = -1;	/* set via acpi_boot_init() */
 
-static int __init parity(u8 v)
+static bool __init parity(u8 v)
 {
 	int x = 0;
 	int i;
@@ -30,7 +30,7 @@ static int __init parity(u8 v)
 		v >>= 1;
 	}
 
-	return x;
+	return !!x;
 }
 
 static void __init sbf_write(u8 v)
@@ -66,14 +66,14 @@ static u8 __init sbf_read(void)
 	return v;
 }
 
-static int __init sbf_value_valid(u8 v)
+static bool __init sbf_value_valid(u8 v)
 {
 	if (v & SBF_RESERVED)		/* Reserved bits */
-		return 0;
+		return false;
 	if (!parity(v))
-		return 0;
+		return false;
 
-	return 1;
+	return true;
 }
 
 static int __init sbf_init(void)

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@`
`20`	`20`
`21`	`21`	`int sbf_port __initdata = -1; /* set via acpi_boot_init() */`
`22`	`22`
`23`		`-static int __init parity(u8 v)`
	`23`	`+static bool __init parity(u8 v)`
`24`	`24`	`{`
`25`	`25`	`int x = 0;`
`26`	`26`	`int i;`
`@@ -30,7 +30,7 @@ static int __init parity(u8 v)`
`30`	`30`	`v >>= 1;`
`31`	`31`	`}`
`32`	`32`
`33`		`- return x;`
	`33`	`+ return !!x;`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`static void __init sbf_write(u8 v)`
`@@ -66,14 +66,14 @@ static u8 __init sbf_read(void)`
`66`	`66`	`return v;`
`67`	`67`	`}`
`68`	`68`
`69`		`-static int __init sbf_value_valid(u8 v)`
	`69`	`+static bool __init sbf_value_valid(u8 v)`
`70`	`70`	`{`
`71`	`71`	`if (v & SBF_RESERVED) /* Reserved bits */`
`72`		`- return 0;`
	`72`	`+ return false;`
`73`	`73`	`if (!parity(v))`
`74`		`- return 0;`
	`74`	`+ return false;`
`75`	`75`
`76`		`- return 1;`
	`76`	`+ return true;`
`77`	`77`	`}`
`78`	`78`
`79`	`79`	`static int __init sbf_init(void)`