Skip to content

Commit 5726b68

Browse files
Li Qiangbroonie
authored andcommitted
ASoC: amd/sdw_utils: avoid NULL deref when devm_kasprintf() fails
devm_kasprintf() may return NULL on memory allocation failure, but the debug message prints cpus->dai_name before checking it. Move the dev_dbg() call after the NULL check to prevent potential NULL pointer dereference. Fixes: cb8ea62 ("ASoC: amd/sdw_utils: add sof based soundwire generic machine driver") Signed-off-by: Li Qiang <liqiang01@kylinos.cn> Link: https://patch.msgid.link/20251015075530.146851-1-liqiang01@kylinos.cn Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 7a37291 commit 5726b68

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

sound/soc/amd/acp/acp-sdw-sof-mach.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,9 +176,9 @@ static int create_sdw_dailink(struct snd_soc_card *card,
176176
cpus->dai_name = devm_kasprintf(dev, GFP_KERNEL,
177177
"SDW%d Pin%d",
178178
link_num, cpu_pin_id);
179-
dev_dbg(dev, "cpu->dai_name:%s\n", cpus->dai_name);
180179
if (!cpus->dai_name)
181180
return -ENOMEM;
181+
dev_dbg(dev, "cpu->dai_name:%s\n", cpus->dai_name);
182182

183183
codec_maps[j].cpu = 0;
184184
codec_maps[j].codec = j;

0 commit comments

Comments
 (0)