net: fsl_pq_mdio: Fix device node reference leak in fsl_pq_mdio_probe

Erickkaranja · kuba-moo · commit 521405cb54cd · 2025-10-06T11:22:40.000-07:00
Add missing of_node_put call to release device node tbi obtained via for_each_child_of_node. Fixes: afae5ad ("net/fsl_pq_mdio: streamline probing of MDIO nodes") Signed-off-by: Erick Karanja <karanja99erick@gmail.com> Link: https://patch.msgid.link/20251002174617.960521-1-karanja99erick@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
diff --git a/drivers/net/ethernet/freescale/fsl_pq_mdio.c b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
@@ -479,10 +479,12 @@ static int fsl_pq_mdio_probe(struct platform_device *pdev)
 					"missing 'reg' property in node %pOF\n",
 					tbi);
 				err = -EBUSY;
+				of_node_put(tbi);
 				goto error;
 			}
 			set_tbipa(*prop, pdev,
 				  data->get_tbipa, priv->map, &res);
+			of_node_put(tbi);
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -479,10 +479,12 @@ static int fsl_pq_mdio_probe(struct platform_device *pdev)`
`479`	`479`	`"missing 'reg' property in node %pOF\n",`
`480`	`480`	`tbi);`
`481`	`481`	`err = -EBUSY;`
	`482`	`+ of_node_put(tbi);`
`482`	`483`	`goto error;`
`483`	`484`	`}`
`484`	`485`	`set_tbipa(*prop, pdev,`
`485`	`486`	`data->get_tbipa, priv->map, &res);`
	`487`	`+ of_node_put(tbi);`
`486`	`488`	`}`
`487`	`489`	`}`
`488`	`490`