Skip to content

Commit 5176458

Browse files
committed
platform/x86:intel/vsec: Change return type of intel_vsec_register
JIRA: https://issues.redhat.com/browse/RHEL-110838 commit 812bca7 Author: Xi Pardee <xi.pardee@linux.intel.com> Date: Fri Apr 25 12:52:29 2025 -0700 platform/x86:intel/vsec: Change return type of intel_vsec_register Change return type of intel_vsec_register() to int. The current implementation does not indicate if the register fail or not. Change to return error code if it fails or if INTEL_VSEC config is not set. This is a preparation step to introduce a new SSRAM Telemetry driver that will be using this API. Signed-off-by: Xi Pardee <xi.pardee@linux.intel.com> Link: https://lore.kernel.org/r/20250425195237.493129-2-xi.pardee@linux.intel.com Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Signed-off-by: Steve Best <sbest@redhat.com>
1 parent d87c670 commit 5176458

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

drivers/platform/x86/intel/vsec.c

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -338,13 +338,16 @@ static bool intel_vsec_walk_vsec(struct pci_dev *pdev,
338338
return have_devices;
339339
}
340340

341-
void intel_vsec_register(struct pci_dev *pdev,
341+
int intel_vsec_register(struct pci_dev *pdev,
342342
struct intel_vsec_platform_info *info)
343343
{
344344
if (!pdev || !info || !info->headers)
345-
return;
345+
return -EINVAL;
346346

347-
intel_vsec_walk_header(pdev, info);
347+
if (!intel_vsec_walk_header(pdev, info))
348+
return -ENODEV;
349+
else
350+
return 0;
348351
}
349352
EXPORT_SYMBOL_NS_GPL(intel_vsec_register, "INTEL_VSEC");
350353

include/linux/intel_vsec.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,12 +139,13 @@ static inline struct intel_vsec_device *auxdev_to_ivdev(struct auxiliary_device
139139
}
140140

141141
#if IS_ENABLED(CONFIG_INTEL_VSEC)
142-
void intel_vsec_register(struct pci_dev *pdev,
142+
int intel_vsec_register(struct pci_dev *pdev,
143143
struct intel_vsec_platform_info *info);
144144
#else
145-
static inline void intel_vsec_register(struct pci_dev *pdev,
145+
static inline int intel_vsec_register(struct pci_dev *pdev,
146146
struct intel_vsec_platform_info *info)
147147
{
148+
return -ENODEV;
148149
}
149150
#endif
150151
#endif

0 commit comments

Comments
 (0)