Merge: redhat/spec: Install all selftests in a single step

MR: https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-10/-/merge_requests/286

JIRA: https://issues.redhat.com/browse/RHEL-70889

Upstream status: RHEL-only

    The `make install` command for selftests emits all (sub)test names to
    kselftest-list.txt. The problem is that each invocation of the command
    overrides the file so running `make install` multiple times (which we do
    as we build livepatch selftests separately) will result in an incomplete
    kselftest-list.txt.

    To fix this, separate the build stage from the install stage and make
    sure that the install target is called only once for all the previously
    built selftest targets.

Signed-off-by: Viktor Malik <vmalik@redhat.com>

Approved-by: Felix Maurer <fmaurer@redhat.com>
Approved-by: Hangbin Liu <haliu@redhat.com>
Approved-by: Herton R. Krzesinski <herton@redhat.com>
Approved-by: CKI KWF Bot <cki-ci-bot+kwf-gitlab-com@redhat.com>

Merged-by: Jan Stancek <jstancek@redhat.com>

Author: jstancek

redhat/kernel.spec.template

@@ -3222,7 +3222,8 @@ pushd tools/testing/selftests
 %undefine _fortify_level
 export CFLAGS="%{build_cflags}"
 
-%{make} %{?_smp_mflags} EXTRA_CFLAGS="${RPM_OPT_FLAGS}" EXTRA_CXXFLAGS="${RPM_OPT_FLAGS}" EXTRA_LDFLAGS="%{__global_ldflags}" ARCH=$Arch V=1 TARGETS="bpf cgroup mm net net/forwarding net/mptcp netfilter tc-testing memfd drivers/net/bonding iommu cachestat" SKIP_TARGETS="" $force_targets INSTALL_PATH=%{buildroot}%{_libexecdir}/kselftests VMLINUX_H="${RPM_VMLINUX_H}" install
+TARGETS="bpf cgroup mm net net/forwarding net/mptcp netfilter tc-testing memfd drivers/net/bonding iommu cachestat"
+%{make} %{?_smp_mflags} EXTRA_CFLAGS="${RPM_OPT_FLAGS}" EXTRA_CXXFLAGS="${RPM_OPT_FLAGS}" EXTRA_LDFLAGS="%{__global_ldflags}" ARCH=$Arch V=1 TARGETS="$TARGETS" SKIP_TARGETS="" $force_targets VMLINUX_H="${RPM_VMLINUX_H}"
 
 # Restore the original level of source fortification
 %define _fortify_level %{_fortify_level_bak}
@@ -3232,9 +3233,13 @@ export CFLAGS="%{build_cflags}"
 	# kernel livepatching selftest test_modules will build against
 	# /lib/modules/$(shell uname -r)/build tree unless KDIR is set
 	export KDIR=$(realpath $(pwd)/../../..)
-	%{make} %{?_smp_mflags} ARCH=$Arch V=1 TARGETS="livepatch" SKIP_TARGETS="" $force_targets INSTALL_PATH=%{buildroot}%{_libexecdir}/kselftests VMLINUX_H="${RPM_VMLINUX_H}" install || true
+	%{make} %{?_smp_mflags} ARCH=$Arch V=1 TARGETS="livepatch" SKIP_TARGETS="" $force_targets VMLINUX_H="${RPM_VMLINUX_H}" && TARGETS="${TARGETS} livepatch" || true
 %endif
 
+# We must install all the targets in a single step as each `make install`
+# command overrides the kselftest-list.txt file.
+%{make} ARCH=$Arch TARGETS="${TARGETS}" SKIP_TARGETS="" $force_targets INSTALL_PATH=%{buildroot}%{_libexecdir}/kselftests install
+
 # 'make install' for bpf is broken and upstream refuses to fix it.
 # Install the needed files manually.
 %{log_msg "install selftests"}