Skip to content

Commit 4d15242

Browse files
committed
rpmsg: glink: Release driver_override
JIRA: https://issues.redhat.com/browse/RHEL-78824 commit fb80ef6 Author: Bjorn Andersson <quic_bjorande@quicinc.com> Date: Mon Jan 9 14:39:31 2023 -0800 rpmsg: glink: Release driver_override Upon termination of the rpmsg_device, driver_override needs to be freed to avoid leaking the potentially assigned string. Fixes: 42cd402 ("rpmsg: Fix kfree() of static memory on setting driver_override") Fixes: 39e4776 ("rpmsg: Add driver_override device attribute for rpmsg_device") Reviewed-by: Chris Lew <quic_clew@quicinc.com> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> Signed-off-by: Bjorn Andersson <andersson@kernel.org> Link: https://lore.kernel.org/r/20230109223931.1706429-1-quic_bjorande@quicinc.com Signed-off-by: Jared Kangas <jkangas@redhat.com>
1 parent 00eaa99 commit 4d15242

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/rpmsg/qcom_glink_native.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1448,6 +1448,7 @@ static void qcom_glink_rpdev_release(struct device *dev)
14481448
{
14491449
struct rpmsg_device *rpdev = to_rpmsg_device(dev);
14501450

1451+
kfree(rpdev->driver_override);
14511452
kfree(rpdev);
14521453
}
14531454

@@ -1691,6 +1692,7 @@ static void qcom_glink_device_release(struct device *dev)
16911692

16921693
/* Release qcom_glink_alloc_channel() reference */
16931694
kref_put(&channel->refcount, qcom_glink_channel_release);
1695+
kfree(rpdev->driver_override);
16941696
kfree(rpdev);
16951697
}
16961698

0 commit comments

Comments
 (0)