Skip to content

Commit 4cea546

Browse files
committed
gfs2: glock holder GL_NOPID fix
jira LE-12345 Rebuild_History Non-Buildable kernel-5.14.0-570.12.1.el9_6 commit-author Andreas Gruenbacher <agruenba@redhat.com> commit f83f897 Glocks are always actively acquired by processes, but as indicated by the GL_NOPID holder flag, some of them are then associated with objects like cached inodes rather than the process that acquired them. As such, for those glock holders, it makes little sense to dump which processes originally acquired them. Therefore, gfs2 is trying to hide the identity of the processes that acquired those glocks. The code for doing that is incorrect though, so fix it. Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com> (cherry picked from commit f83f897) Signed-off-by: Jonathan Maple <jmaple@ciq.com>
1 parent 2a94234 commit 4cea546

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

fs/gfs2/glock.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1464,9 +1464,7 @@ static inline bool pid_is_meaningful(const struct gfs2_holder *gh)
14641464
{
14651465
if (!(gh->gh_flags & GL_NOPID))
14661466
return true;
1467-
if (gh->gh_state == LM_ST_UNLOCKED)
1468-
return true;
1469-
return false;
1467+
return !test_bit(HIF_HOLDER, &gh->gh_iflags);
14701468
}
14711469

14721470
/**

0 commit comments

Comments
 (0)